Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the menu without using the menu-in-menu plugin? #21

Closed
bobbingwide opened this issue Aug 8, 2021 · 2 comments
Closed

Implement the menu without using the menu-in-menu plugin? #21

bobbingwide opened this issue Aug 8, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@bobbingwide
Copy link
Owner

bobbingwide commented Aug 8, 2021

In the live site the menu-in-menu plugin is used to complete the drop down menus.
There are 4 sub menus: SB, Selected Bits, Section B and Specially Built.

What's the easiest way of incorporating these menus into the main menu?

  • Can it be done with drag and drop?
  • If not, then I'll just have to add the menu items individually.

Requirement

  • Main menu to match the existing live site
  • Easiest way to implement
  • Also, the styling still needs improving.

Proposed solution

  • Try implementing with Drag and Drop in the Site Editor or tempate part editor
  • If that fails do each item manually
@bobbingwide bobbingwide added the enhancement New feature or request label Aug 8, 2021
@bobbingwide bobbingwide self-assigned this Aug 8, 2021
@bobbingwide
Copy link
Owner Author

Try implementing with Drag and Drop in the Site Editor or tempate part editor. If that fails do each item manually

  • You can't insert a menu into a menu
  • The easiest solution was to insert a vertical navigation menu for each of the 4 submenus
  • Copy and paste the navigation-link blocks into the main-menu.html file
  • I haven't yet removed the unnecessary attributes that may prevent the menu from working properly on the live site

eg. Navigation link produced by inserting the vertical navigation

<!-- wp:navigation-link {"label":"Standard Book","type":"bigram","id":4328,"url":"https://s.b/bigram/bigram/standard-book-2/","kind":"post-type","isTopLevelLink":true} /-->

The form of the navigation link we can get away with doesn't require the following attributes: type, id, kind, isTopLeveLink

eg

<!-- wp:navigation-link {"label":"Standard Book","url":"https://s.b/bigram/bigram/standard-book-2/"} /-->

bobbingwide added a commit that referenced this issue Aug 8, 2021
bobbingwide added a commit that referenced this issue Aug 8, 2021
bobbingwide added a commit that referenced this issue May 10, 2022
@bobbingwide
Copy link
Owner Author

Delivered in SB v0.2.1 so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant