Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] invalid OG image tag when no image is present #66

Closed
ankedsgn opened this issue Jan 24, 2018 · 4 comments
Closed

[BUG] invalid OG image tag when no image is present #66

ankedsgn opened this issue Jan 24, 2018 · 4 comments

Comments

@ankedsgn
Copy link
Contributor

ankedsgn commented Jan 24, 2018

Ohai!

When a contenttype contains no images at all, the extension prints
<meta property="og:image" content="http://nameofdomain.com/files/&quot;&quot;" />

Preferably, it should not print an image tag at all (ignoring for now that FB kinda requires a image tag, but that's another issue).

Thx!

SEO extension version 1.0.7

@GwendolenLynch
Copy link
Contributor

Quoth http://ogp.me

The four required properties for every page are:

  • og:title - The title of your object as it should appear within the graph, e.g., "The Rock".
  • og:type - The type of your object, e.g., "video.movie". Depending on the type you specify, other properties may also be required.
  • og:image - An image URL which should represent your object within the graph.
  • og:url - The canonical URL of your object that will be used as its permanent ID in the graph, e.g., "http://www.imdb.com/title/tt0117500/".

@ankedsgn
Copy link
Contributor Author

ankedsgn commented Jan 24, 2018

@GawainLynch Exactly. I already created another issue (#67 ) with a feature request to include a default, at @bobdenotter 's request. :)

@GwendolenLynch
Copy link
Contributor

Yeah, saw that one come through after … Not sure how we missed it here, I've had that in my OG extension since day 1 (early 2.0-dev)

@ankedsgn
Copy link
Contributor Author

Well, in 99% of the pages there is an image present. I just built a site that had a contenttype without any media. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants