Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to turn off UNKNOWN_PRAGMA checking #72

Closed
wants to merge 1 commit into from

Conversation

zbuc
Copy link
Contributor

@zbuc zbuc commented Jan 13, 2012

We were using your Mustache.php(good work) and had quite a few templates sitting around.

We wrote those templates a while back -- so they referenced some old pragmas, e.g. DOT-NOTATION and IMPLICIT-ITERATOR, that aren't valid any more.

We use the same Mustache templates in different languages and some of the other implementations require those pragmas -- so being able to turn off unknown pragma checking is important to us.

There was a _throwsException config option for the unknown pragma exception but it seems that when the exceptions are actually thrown, it's not being checked.

This patch seemed to work well for us.

I don't have a test for it -- I hacked it together quickly and have to get back to some other things but you can test the behavior by including an invalid pragma in a template with and without my patch.

Thanks!

@bobthecow
Copy link
Owner

Thank you. This fix has been merged into dev and will go out in the next release.

@bobthecow bobthecow closed this Jan 16, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants