pvh: Add Bytes() for GDT. #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix typo. Signed-off-by: Nobuhiro MIKI <nob@bobuhiro11.net>
ChriMarMe
approved these changes
Sep 21, 2023
Comment on lines
+136
to
+139
| type GDT [4]uint64 | ||
|
|
||
| func CreateGDT() GDT { | ||
| var gdtTable GDT |
There was a problem hiding this comment.
Not sure if we need a struct for GDT.
Sure, Byte function is cleaner, but we use it in one instance only once.
Also GDT can have more than 4 entries. :)
I leave it to you
There was a problem hiding this comment.
Thanks for the review!
As you said, it's only used once now, but Bytes() functions are implemented the same meaning for various data structures and I find it easy to read.
If we need to make the number of entries variable length, we will handle that in a future PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.