Import tests from Google V8 #3

jugglinmike · 2015-03-03T17:40:50Z

These tests are derived from the following files within the Google V8
project:

test/mjsunit/harmony/arrow-functions.js

These tests are derived from the following files within the Google V8 project: test/mjsunit/harmony/arrow-functions.js

…set #3 id:100001 of https://codereview.chromium.org/976203003/) Reason for revert: Some tests still flaky Original issue's description: > CpuProfiler: enable tests except four failing tests. > > Four tests are failing due to a problem with no frame ranges. > > BUG= > LOG=n > > Committed: https://crrev.com/2be160e726f2be6272b77e53fbd556aded6024f1 > Cr-Commit-Position: refs/heads/master@{#27035} TBR=yurys@chromium.org,svenpanne@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/987553005 Cr-Commit-Position: refs/heads/master@{#27037}

…he StoreBuffer/SlotsBuffer. (patchset #3 id:40001 of https://codereview.chromium.org/988363002/) Reason for revert: Increased rate of Chrome crashes. Requires further investigation. Original issue's description: > Reland of Remove slots that point to unboxed doubles from the StoreBuffer/SlotsBuffer. > > The problem is that tagged slot could become a double slot after migrating of an object to another map with "shifted" fields (for example as a result of generalizing immutable data property to a data field). > This CL also adds useful machinery that helps triggering incremental write barriers. > > BUG=chromium:454297, chromium:465273 > LOG=Y > > Committed: https://crrev.com/6d0677d845c47ab9fa297de61d0e3d8e5480a02a > Cr-Commit-Position: refs/heads/master@{#27141} TBR=hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:454297, chromium:465273 Review URL: https://codereview.chromium.org/1004623003 Cr-Commit-Position: refs/heads/master@{#27207}

#3 id:40001 of https://codereview.chromium.org/1014813003/) Reason for revert: Layout test failures. Please update layout test expectations before landing this, in order to not block the roll. Original issue's description: > [es6] Object.getPrototypeOf should work with values > > The final spec for Object.getPrototypeOf calls ToObject on the > parameter, which means that it should only throw for null and > undefined. For other non object values the prototype of the wrapper > should be used. > > BUG=v8:3964 > LOG=N > R=adamk, rossberg@chromium.org > > Committed: https://crrev.com/ea463a916bbe5994b0d2d04e8075058b373b2e2c > Cr-Commit-Position: refs/heads/master@{#27354} TBR=adamk@chromium.org,rossberg@chromium.org,arv@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3964 Review URL: https://codereview.chromium.org/1033623002 Cr-Commit-Position: refs/heads/master@{#27389}

…https://codereview.chromium.org/1022333004/) Reason for revert: [Sheriff] This seems to change layout test expectations of some tests, e.g.: http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/2317 Expectation example: https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_64__dbg_/2317/layout-test-results/fast/events/window-onerror-11-pretty-diff.html Please add a needsmanualrebaseline expectation to the tests affected by this change on the blink side first before relanding. Original issue's description: > [V8] Removed SourceLocationRestrict > > This method uses in messages.js in GetSourceLine and GetPositionInLine. This methods uses in v8::Message API methods and there is no documentation about it. > Method looks obsolete. > One of the strange side effect is shown by attached issue. > > BUG=chromium:468781 > R=yangguo@chromium.org > LOG=Y > > Committed: https://crrev.com/b563ceac0f95551a128a1403cdbacc7aefcdabaf > Cr-Commit-Position: refs/heads/master@{#27374} TBR=yangguo@chromium.org,kozyatinskiy@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:468781 Review URL: https://codereview.chromium.org/1028413002 Cr-Commit-Position: refs/heads/master@{#27398}

…//codereview.chromium.org/1041483004/) Reason for revert: Reverting due to JSOn parser failures Original issue's description: > Fix JSON parser Handle leak > > R=verwaest@chromium.org > BUG=v8:3976 > LOG=y > > Committed: https://crrev.com/1ec850383bb82f6d8bebc7416e5f50b649d1eeaa > Cr-Commit-Position: refs/heads/master@{#27512} TBR=verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3976 Review URL: https://codereview.chromium.org/1052593002 Cr-Commit-Position: refs/heads/master@{#27562}

…buffers (patchset #3 id:40001 of https://codereview.chromium.org/1035763002/) Reason for revert: Got one dev-channel with this. Should be enough. Original issue's description: > Add CHECKs when updating pointers from the slots and store buffers > > We want to verify that we always overwrite heap objects with heap > objects, and non-heap objects with non-heap objects > > BUG=chromium:452095 > R=hpayer@chromium.org > LOG=n > > Committed: https://crrev.com/58fbcfac8ae82b1241f07e1b8ea81a5973514c11 > Cr-Commit-Position: refs/heads/master@{#27479} TBR=hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:452095 Review URL: https://codereview.chromium.org/1052713002 Cr-Commit-Position: refs/heads/master@{#27565}

…arking with (patchset #3 id:40001 of https://codereview.chromium.org/1156463002/) Reason for revert: [Sheriff] Speculative revert because chromebook is really misbehaving: http://build.chromium.org/p/client.v8/builders/V8%20Arm/builds/2109 I also triggered a retry with the failing build to be sure. If the revert doesn't help or the bot had a scary hiccup, this can reland. Original issue's description: > Pass GC flags to incremental marker and start incremental marking with > reduce memory footprint in idle notification. > > BUG= > > Committed: https://crrev.com/4656308147b12405037678b1ab192fb4f2437bbc > Cr-Commit-Position: refs/heads/master@{#28567} TBR=hpayer@chromium.org,ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1151143002 Cr-Commit-Position: refs/heads/master@{#28568}

…remental marking with (patchset #1 id:1 of https://codereview.chromium.org/1151143002/) Reason for revert: Wasn't the reason... Original issue's description: > Revert of Pass GC flags to incremental marker and start incremental marking with (patchset #3 id:40001 of https://codereview.chromium.org/1156463002/) > > Reason for revert: > [Sheriff] Speculative revert because chromebook is really misbehaving: > http://build.chromium.org/p/client.v8/builders/V8%20Arm/builds/2109 > > I also triggered a retry with the failing build to be sure. If the revert doesn't help or the bot had a scary hiccup, this can reland. > > Original issue's description: > > Pass GC flags to incremental marker and start incremental marking with > > reduce memory footprint in idle notification. > > > > BUG= > > > > Committed: https://crrev.com/4656308147b12405037678b1ab192fb4f2437bbc > > Cr-Commit-Position: refs/heads/master@{#28567} > > TBR=hpayer@chromium.org,ulan@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/634c58a4f10b346a98208ec34d169e1bdb04e1b7 > Cr-Commit-Position: refs/heads/master@{#28568} TBR=hpayer@chromium.org,ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1157613002 Cr-Commit-Position: refs/heads/master@{#28569}

…01 of https://codereview.chromium.org/1154483002/) Reason for revert: [Sheriff] Speculative revert for gc stress failures: http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/481 Original issue's description: > Hook up more import/exports in natives. > > R=jkummerow@chromium.org > > Committed: https://crrev.com/7a918ac9658d11778f39593bfcc19d7c506defd9 > Cr-Commit-Position: refs/heads/master@{#28573} > > Committed: https://crrev.com/e13a39dd7f4062898709d7c68900677df0513995 > Cr-Commit-Position: refs/heads/master@{#28578} TBR=jkummerow@chromium.org,erik.corry@gmail.com,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1154743003 Cr-Commit-Position: refs/heads/master@{#28584}

id:1 of https://codereview.chromium.org/1154743003/) Reason for revert: Unrelated failure that was uncovered by this CL has been fixed (https://codereview.chromium.org/1152243002/) Original issue's description: > Revert of Hook up more import/exports in natives. (patchset #3 id:40001 of https://codereview.chromium.org/1154483002/) > > Reason for revert: > [Sheriff] Speculative revert for gc stress failures: > http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/481 > > Original issue's description: > > Hook up more import/exports in natives. > > > > R=jkummerow@chromium.org > > > > Committed: https://crrev.com/7a918ac9658d11778f39593bfcc19d7c506defd9 > > Cr-Commit-Position: refs/heads/master@{#28573} > > > > Committed: https://crrev.com/e13a39dd7f4062898709d7c68900677df0513995 > > Cr-Commit-Position: refs/heads/master@{#28578} > > TBR=jkummerow@chromium.org,erik.corry@gmail.com,yangguo@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/eb0024d1dbdda5f51b006dd54887404ee6c5cbfc > Cr-Commit-Position: refs/heads/master@{#28584} TBR=jkummerow@chromium.org,erik.corry@gmail.com,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1149773003 Cr-Commit-Position: refs/heads/master@{#28608}

…01 of https://codereview.chromium.org/1159453004/) Reason for revert: Breaks Linux - arm64 - sim - MSAN TBR=jochen Original issue's description: > Add SIMD 128 alignment support to Heap. > Adds SIMD 128 alignment sizes and masks. > Adds support in Heap for SIMD alignments and fills. > Reworks cctest so that each test independently aligns its allocation address, rather than depending on the previous tests ending state. Adds test cases for SIMD. > > LOG=N > BUG=v8:4124 TBR=hpayer@chromium.org,jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4124 Review URL: https://codereview.chromium.org/1169453003 Cr-Commit-Position: refs/heads/master@{#28768}

…hset #3 id:40001 of https://codereview.chromium.org/1154423014/) Reason for revert: Breaks Win32 mjsunit/harmony/typedarray-reduce, see http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/7121/steps/Check/logs/typedarray-reduce for details. Original issue's description: > Implement %TypedArray%.prototype.{reduce,reduceRight} > > This patch implements the last two methods on TypedArrays. These > were previously committed and led to a test failure. > > BUG=v8:3578 > LOG=Y > R=adamk > > Committed: https://crrev.com/95d779ecc9816ac20c1565bebeeac6a1ef29f1c7 > Cr-Commit-Position: refs/heads/master@{#28773} TBR=adamk@chromium.org,dehrenberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3578 Review URL: https://codereview.chromium.org/1162043008 Cr-Commit-Position: refs/heads/master@{#28777}

…ess indicators. (patchset #3 id:40001 of https://codereview.chromium.org/1171943002/) Reason for revert: might break stuff Original issue's description: > [test] Refactoring - Use subject/observer pattern for progress indicators. > > This should prevent bugs caused by missing super calls in > overridden methods. The assumption is that methods of > different indicators are independent. > > Committed: https://crrev.com/fbe973ff1722a6158a5b2babce9c1a32d26a1d3b > Cr-Commit-Position: refs/heads/master@{#28866} TBR=jkummerow@chromium.org,tandrii@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1163373005 Cr-Commit-Position: refs/heads/master@{#28869}

… for progress indicators. (patchset #1 id:1 of https://codereview.chromium.org/1163373005/) Reason for revert: All build problems had other causes. Original issue's description: > Revert of [test] Refactoring - Use subject/observer pattern for progress indicators. (patchset #3 id:40001 of https://codereview.chromium.org/1171943002/) > > Reason for revert: > might break stuff > > Original issue's description: > > [test] Refactoring - Use subject/observer pattern for progress indicators. > > > > This should prevent bugs caused by missing super calls in > > overridden methods. The assumption is that methods of > > different indicators are independent. > > > > Committed: https://crrev.com/fbe973ff1722a6158a5b2babce9c1a32d26a1d3b > > Cr-Commit-Position: refs/heads/master@{#28866} > > TBR=jkummerow@chromium.org,tandrii@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/2a3962d9d2a7415378811f4d56522531332d5a3e > Cr-Commit-Position: refs/heads/master@{#28869} TBR=jkummerow@chromium.org,tandrii@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1176863002 Cr-Commit-Position: refs/heads/master@{#28901}

…hset #3 id:40001 of https://codereview.chromium.org/1041683002/) Reason for revert: Revert, due to problems with stale build artefacts uncovered by this. Details: https://code.google.com/p/v8/issues/detail?id=4171 Original issue's description: > Re-land: Enable external startup by default on Linux. > > crrev.com/1016603004 should have fixed the issues that broke this last time. > > Notes: > - The current functionality is meant to stay. If you prefer the old way, > just set v8_use_external_startup_data=0. > - You might notice this if you call d8 via PATH. Either explicitly tell d8 > where your external snapshot/built-ins are, or change the build options > as above. > - This follows Chromium practice, that mostly uses this feature these days. > - Other platforms to follow later. > > BUG= > > Committed: https://crrev.com/bb9c774c164c3552b67b4f1b60809852a44f2ecd > Cr-Commit-Position: refs/heads/master@{#28858} TBR=jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1177883003 Cr-Commit-Position: refs/heads/master@{#28929}

…m. (patchset #3 id:40001 of https://codereview.chromium.org/1178853002/) Reason for revert: [Sheriff] tsan failures: http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/4240 Original issue's description: > [heap] Unify the immortal immovable root detection mechanism. > > Uniformly use the Heap::GetRootListIndex() and > Heap::RootIsImmortalImmovable() methods to detect immortal immovable > roots in the optimizing compilers. > > R=jarin@chromium.org > > Committed: https://crrev.com/84e83da99a72edc169367bf88588b1a2f10c2e08 > Cr-Commit-Position: refs/heads/master@{#28933} TBR=jarin@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1178083003 Cr-Commit-Position: refs/heads/master@{#28934}

@yangguo

…powerful alternatives where relevant. (patchset #3 id:40001 of https://codereview.chromium.org/1178503004/) Reason for revert: Blocks revert of https://codereview.chromium.org/1175973002 Original issue's description: > Replace SetObjectProperty / DefineObjectProperty with less powerful alternatives where relevant. > > @yangguo: please look at the debugger part of the CL. > @ishell: please look at the rest. > > Additionally: > - Ensure the LookupIterator for named properties does not accidentally get indexes in. > - Fix the return value for typed array assignments to be the incoming value. > > BUG=v8:4137 > LOG=n > > Committed: https://crrev.com/15aa811f8fe2708a757c3b53ca89db736aa8b222 > Cr-Commit-Position: refs/heads/master@{#28954} TBR=yangguo@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4137 Review URL: https://codereview.chromium.org/1181733002 Cr-Commit-Position: refs/heads/master@{#28957}

…powerful alternatives where relevant. (patchset #3 id:40001 of https://codereview.chromium.org/1178503004/) BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1180943002 Cr-Commit-Position: refs/heads/master@{#29000}

…001 of https://codereview.chromium.org/1179873003/) Reason for revert: [Sheriff] Breaks arm debug compile: http://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20debug%20builder/builds/4308 Original issue's description: > Serializer: support all alignment kinds. > > We use an alignment prefix for unusual alignment kinds (not kWordAligned). > This will cause new objects to be aligned in ReadObject, and back references > to be aligned to skip padding. > > The motivation to change the undefined next sentinel in WeakCell is this: > When the deserializer aligns an object, it requires filler maps to already > exist to create filler objects as padding. However, deserializing the > filler map leads to deserializing NaN, which as heap number is aligned: > filler map > meta map > weak cell cache > undefined > NaN > If we use the-hole instead of undefined as sentinel, it works. > > R=jochen@chromium.org,bbudge@chromium.org > BUG=v8:4178 > LOG=N > > Committed: https://crrev.com/2146ab75387d47eef6582bd8c2d0cfc6c42b68b6 > Cr-Commit-Position: refs/heads/master@{#29044} TBR=jochen@chromium.org,bbudge@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4178 Review URL: https://codereview.chromium.org/1173253006 Cr-Commit-Position: refs/heads/master@{#29045}

https://codereview.chromium.org/1153233003/) Reason for revert: Deoptimizer crashes. Original issue's description: > Re-land new insertion write barrier. > > BUG= > > Committed: https://crrev.com/72f850458cb530d871cf3fb6442660555dc51bc2 > Cr-Commit-Position: refs/heads/master@{#29052} TBR=ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1176243015 Cr-Commit-Position: refs/heads/master@{#29123}

…y) (patchset #3 id:60001 of https://codereview.chromium.org/1195613003/) Reason for revert: Fails on V8 Linux - isolates (http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20isolates/builds/4128) Original issue's description: > Add d8 API for spawning function on a new thread (Second try) > > This API closely matches the Worker API. The differences: > > 1) The argument to the Worker constructor is a function to run, not a script. > 2) Receiving a message from a worker is a synchronous API (as there is no event > loop). > > The serialization done here is not robust as the real DOM implementation. For > example, recursive data structures or otherwise duplicated objects are not > allowed. > > BUG=chromium:497295 > R=jochen@chromium.org > LOG=n > > Review URL: https://codereview.chromium.org/1185643004 > > Cr-Commit-Position: refs/heads/master@{#29126} > > Committed: https://crrev.com/ec2eaf712ecee6b4891c0458f2397e04a1f9b339 > Cr-Commit-Position: refs/heads/master@{#29158} TBR=jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:497295 Review URL: https://codereview.chromium.org/1191373005 Cr-Commit-Position: refs/heads/master@{#29161}

…set #3 id:40001 of https://codereview.chromium.org/1202963005/) Reason for revert: [Sheriff] Breaks layout tests. Please fix upstream blink first. http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Mac/builds/574 Please consider extra blink trybots on a reland. Original issue's description: > Fix receiver when calling eval() bound by with scope > > Thanks to André Bargull for the report. > > BUG=v8:4214 > LOG=N > R=arv@chromium.org, mstarzinger@chromium.org > > Committed: https://crrev.com/3c5f0db3a1768ade68108bf003676ce378d1cbdc > Cr-Commit-Position: refs/heads/master@{#29259} TBR=arv@chromium.org,mstarzinger@chromium.org,verwaest@chromium.org,wingo@igalia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4214 Review URL: https://codereview.chromium.org/1201273004 Cr-Commit-Position: refs/heads/master@{#29267}

…atchset #3 id:40001 of https://codereview.chromium.org/1211453002/) Reason for revert: proxies test failing https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/903/steps/Mjsunit/logs/proxies Original issue's description: > Reland "Keep a canonical list of shared function infos." > > This reverts commit 3164aa7. > > Committed: https://crrev.com/cacb646d80daa429f6915824a741f595db7d5044 > Cr-Commit-Position: refs/heads/master@{#29282} TBR=adamk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1206263002 Cr-Commit-Position: refs/heads/master@{#29285}

…#3 id:40001 of https://codereview.chromium.org/1691723002/ ) Reason for revert: [Sheriff] Speculative revert. Breaks https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/3944 Somehow https://chromium.googlesource.com/v8/v8/+/3a2fbc3a4ed2802b52659df2209b930200d63b29 seems to hide it again and then https://chromium.googlesource.com/v8/v8/+/699e1081a658ff62df6df1efe7db2b250111dedd lets it show up again. Reproduced locally. Original issue's description: > [interpreter] Make d8's TryCatch block be verbose. > > This changes "d8" to no longer report exceptions as being "caught" when > it comes to the catch prediction mechanism in our debugger. This treats > scripts as being truly top-level when it comes to exception handling and > will allow us to properly test the catch prediction mechanism using just > mjsunit tests alone. > > R=yangguo@chromium.org > BUG=v8:4674 > LOG=n > > Committed: https://crrev.com/fb1de271a6bc2c89a1682db8c151cf5fcda86c45 > Cr-Commit-Position: refs/heads/master@{#33898} TBR=yangguo@chromium.org,mstarzinger@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4674 Review URL: https://codereview.chromium.org/1694523003 Cr-Commit-Position: refs/heads/master@{#33921}

…#1 id:1 of https://codereview.chromium.org/1694523003/ ) Reason for revert: No fix needed, original CL was perfectly fine! Original issue's description: > Revert of [interpreter] Make d8's TryCatch block be verbose. (patchset #3 id:40001 of https://codereview.chromium.org/1691723002/ ) > > Reason for revert: > [Sheriff] Speculative revert. Breaks > https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/3944 > > Somehow https://chromium.googlesource.com/v8/v8/+/3a2fbc3a4ed2802b52659df2209b930200d63b29 seems to hide it again and then https://chromium.googlesource.com/v8/v8/+/699e1081a658ff62df6df1efe7db2b250111dedd lets it show up again. > > Reproduced locally. > > Original issue's description: > > [interpreter] Make d8's TryCatch block be verbose. > > > > This changes "d8" to no longer report exceptions as being "caught" when > > it comes to the catch prediction mechanism in our debugger. This treats > > scripts as being truly top-level when it comes to exception handling and > > will allow us to properly test the catch prediction mechanism using just > > mjsunit tests alone. > > > > R=yangguo@chromium.org > > BUG=v8:4674 > > LOG=n > > > > Committed: https://crrev.com/fb1de271a6bc2c89a1682db8c151cf5fcda86c45 > > Cr-Commit-Position: refs/heads/master@{#33898} > > TBR=yangguo@chromium.org,mstarzinger@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4674 > > Committed: https://crrev.com/f9eef1f33d2e5cde8cb948424e7ebf509090aa59 > Cr-Commit-Position: refs/heads/master@{#33921} TBR=yangguo@chromium.org,machenbach@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4674 Review URL: https://codereview.chromium.org/1692133002 Cr-Commit-Position: refs/heads/master@{#33931}

…tps://codereview.chromium.org/1702063002/ ) Reason for revert: [Sheriff] This makes jsfunfuzz unhappy: https://build.chromium.org/p/client.v8/builders/V8%20Fuzzer/builds/7681 Original issue's description: > This patch implements an alternative approach to the rewriting > of non-pattern expressions, according to the (internally circulated) > design document. Details to be provided here. > > 1. RewritableAssignmentExpression has been renamed to RewritableExpression. > It is a wrapper for AST nodes that wait for some potential rewriting > (that may or may not happen). Also, Is... and As... macros now see > through RewritableExpressions. > > 2. The function state keeps a list of rewritable expressions that must be > rewritten only if they are used as non-pattern expressions. > > 3. Expression classifiers are now templates, parameterized by parser > traits. They keep some additional state: a pointer to the list of > non-pattern rewritable expressions. It is important that expression > classifiers be used strictly in a stack fashion, from now on. > > 4. The RewriteNonPattern function has been simplified. > > BUG=chromium:579913 > LOG=N > > Committed: https://crrev.com/7f5c864a6faf2b957b7273891e143b9bde35487c > Cr-Commit-Position: refs/heads/master@{#34154} TBR=rossberg@chromium.org,bmeurer@chromium.org,titzer@chromium.org,nikolaos@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:579913 Review URL: https://codereview.chromium.org/1712203002 Cr-Commit-Position: refs/heads/master@{#34158}

…#3 id:40001 of https://codereview.chromium.org/1730543002/ ) Reason for revert: This breaks `gclient sync` because v8_target_arch isn't defined. gyp: name 'v8_target_arch' is not defined while evaluating condition '(OS=="linux" or OS=="mac") and (target_arch=="ia32" or target_arch=="x64") and (v8_target_arch!="x87" and v8_target_arch!="x32") and coverage==0' in /media/jfb/ssd/v8/v8/build/all.gyp Error: Command '/usr/bin/python v8/build/gyp_v8' returned non-zero exit status 1 in /media/jfb/ssd/v8 Original issue's description: > [coverage] Filter some files from instrumentation. > > This filters test and third_party files to get a speed-up > when running tests and when collecting profile data. > > BUG=chromium:568949 > LOG=n > > Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4 > Cr-Commit-Position: refs/heads/master@{#34216} > > Committed: https://crrev.com/906db7448702a6ac9fab2a445c57cc85f6dd1b1a > Cr-Commit-Position: refs/heads/master@{#34253} TBR=tandrii@chromium.org,kjellander@chromium.org,machenbach@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:568949 Review URL: https://codereview.chromium.org/1737433002 Cr-Commit-Position: refs/heads/master@{#34258}

…tchset #3 id:40001 of https://codereview.chromium.org/1756433002/ ) Reason for revert: [Sheriff] Breaks webkit unittests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/5043 Original issue's description: > [api] Don't go to javascript to construct API functions > > BUG= > R=bmeurer@chromium.org,verwaest@chromium.org > > Committed: https://crrev.com/21a5bfbd2ced6e4a3545bbde712630c0d8734c0b > Cr-Commit-Position: refs/heads/master@{#34411} TBR=bmeurer@chromium.org,verwaest@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1758623002 Cr-Commit-Position: refs/heads/master@{#34419}

…#3 id:40001 of https://codereview.chromium.org/1765673002/ ) Reason for revert: [Sheriff] Breaks chromium win compile: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Win/builds/3844/steps/compile/logs/stdio Original issue's description: > [wasm] Update {i32,i64}.const to use signed leb128 > > R=titzer@chromium.org > R=bradnelson@chromium.org > LOG=n > > Committed: https://crrev.com/4b613a67e0aa4e073946f5f0dd95ee9366c8ca86 > Cr-Commit-Position: refs/heads/master@{#34471} TBR=bradnelson@chromium.org,titzer@chromium.org,binji@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1760363003 Cr-Commit-Position: refs/heads/master@{#34482}

…/codereview.chromium.org/1847103002/ ) Reason for revert: breaks some chromium browser_tests: https://codereview.chromium.org/1848233002/ Original issue's description: > Ship --harmony-regexp-exec > > There are still spec compliance fixes to be made, but this patch > turns the flag to shipping to make sure we get more canary coverage > and performance data from the bots. > > BUG=v8:4602 > LOG=y > > Committed: https://crrev.com/84492bb66b340f4e0df36758e98fddbb10b5d1dc > Cr-Commit-Position: refs/heads/master@{#35181} TBR=littledan@chromium.org,adamk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4602 Review URL: https://codereview.chromium.org/1852673003 Cr-Commit-Position: refs/heads/master@{#35198}

…ttps://codereview.chromium.org/1834373003/ ) Reason for revert: [Sheriff] Likely causing blink crashes: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/3667 Original issue's description: > [heap] Add optimized RecordWrites > BUG= > > Committed: https://crrev.com/5210f167e802a3758aac1f2900a6560c8de07831 > Cr-Commit-Position: refs/heads/master@{#35231} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,cbruni@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1860443003 Cr-Commit-Position: refs/heads/master@{#35235}

…rototype.charAt to TurboFan. (patchset #3 id:40001 of https://codereview.chromium.org/1868963002/ ) Reason for revert: Please rebaseline: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/5992 Original issue's description: > [builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to TurboFan. > > Make these builtins fast by default w/o relying on the > %_StringCharCodeAt and %_StringCharAt intrinsics, which we cannot deal > with well in TurboFan (and ignition). > > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg > R=epertoso@chromium.org > > Committed: https://crrev.com/43d3331d87f68ea7efa1b58f559f33f60e5dacfb > Cr-Commit-Position: refs/heads/master@{#35350} > > Committed: https://crrev.com/253a16f690ab593a95249c34ded9df477ad9a54c > Cr-Commit-Position: refs/heads/master@{#35402} TBR=epertoso@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1877263002 Cr-Commit-Position: refs/heads/master@{#35410}

…ightShift stubs. (patchset #3 id:40001 of https://codereview.chromium.org/1881003002/ ) Reason for revert: Needed to revert https://codereview.chromium.org/1617503003 Original issue's description: > [stubs] Introduce LeftShift, SignedRightShift and UnsignedRightShift stubs. > > Add the stubs for JavaScript's '<<', '>>' and '>>>' operators and lets Ignition make use of them in the respective bytecode handlers. > > Committed: https://crrev.com/599369d6b8e1a5ccdca857def06eebcbacf47dd4 > Cr-Commit-Position: refs/heads/master@{#35433} TBR=bmeurer@chromium.org,epertoso@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1880413002 Cr-Commit-Position: refs/heads/master@{#35444}

A load instruction will implicitely clear the top 32 bits when writing to a W register. This patch avoids generating a `mov` instruction to zero-extend the result in this case. For example, this occurs in the generated code for dispatching to the next bytecode in the interpreter: kind = BYTECODE_HANDLER name = LdaZero compiler = turbofan Instructions (size = 36) 0x32e64c60 0 add x19, x19, #0x1 (1) 0x32e64c64 4 ldrb w0, [x20, x19] 0x32e64c68 8 mov w0, w0 ^^^^^^^^^^ 0x32e64c6c 12 lsl x0, x0, #3 0x32e64c70 16 ldr x1, [x21, x0] 0x32e64c74 20 movz x0, #0x0 0x32e64c78 24 br x1 BUG= Review-Url: https://codereview.chromium.org/1950013003 Cr-Commit-Position: refs/heads/master@{#36038}

…#3 id:40001 of https://codereview.chromium.org/1969693002/ ) Reason for revert: Blocks the roll: https://codereview.chromium.org/1974733002/ Breaks: https://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/136166 Original issue's description: > Change v8_snapshot_toolchain to be a GN build arg. > > It is likely that CrOS and other distros will want to be > able to build the v8 snapshot with a custom toolchain. > > This CL makes snapshot_toolchain a declared build arg, and > renames it to v8_snapshot_toolchain to minimize the risk > of a name collision. > > R=machenbach@chromium.org, jochen@chromium.org > BUG=608596 > > Committed: https://crrev.com/2ae74af8f405f461d8e44d60b978f940673e46c8 > Cr-Commit-Position: refs/heads/master@{#36193} TBR=jochen@chromium.org,dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=608596 Review-Url: https://codereview.chromium.org/1975713002 Cr-Commit-Position: refs/heads/master@{#36199}

This patch adds support for the `Operand2_R_LSL_I` addressing mode to loads and stores. This allows merging a shift instruction into a MemoryOperand. Since the shift immediate is restricted to the log2 of the operation width, the opportunities to hit this are slim. However, Ignition's bytecode handlers hit this case all the time: kind = BYTECODE_HANDLER name = Star compiler = turbofan Instructions (size = 44) 0x23e67280 0 add x1, x19, #0x1 (1) 0x23e67284 4 ldrsb x1, [x20, x1] 0x23e67288 8 sxtw x1, w1 0x23e6728c 12 mov x2, fp 0x23e67290 16 str x0, [x2, x1, lsl #3] ^^^^^^^^^^^^^^^^^^^^^ 0x23e67294 20 add x19, x19, #0x2 (2) 0x23e67298 24 ldrb w1, [x20, x19] 0x23e6729c 28 ldr x1, [x21, x1, lsl #3] ^^^^^^^^^^^^^^^^^^^^^ 0x23e672a0 32 br x1 Additionally, I noticed the optimisation occurs once in both the `StringPrototypeCharAt` and `StringPrototypeCharCodeAt` turbofan stubs. BUG= Review-Url: https://codereview.chromium.org/1972103002 Cr-Commit-Position: refs/heads/master@{#36227}

This patch re-lands #36341 with another fix to make the amd64-generic build work as well. R=machenbach@chromium.org, hablich@chromium.org, adamk@chromium.org BUG=608596, 595653 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:chromeos_daisy_chromium_compile_only_ng,chromeos_amd64-generic_chromium_compile_only_ng,chromeos_x86-generic_chromium_compile_only_ng,linux_chromium_gn_chromeos_rel,linux_chromium_gn_chromeos_dbg Review-Url: https://codereview.chromium.org/1996513005 Cr-Commit-Position: refs/heads/master@{#36390}

https://codereview.chromium.org/2003483002/ ) Reason for revert: Crashes gc stress with custom snapshot: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/5763 Original issue's description: > Refactor script position calculation > > Script position calculation logic (i.e. line & column numbers for a > given code position) is now based on a single method > Script::GetPositionInfo(). Refactored related code in isolate.cc and > js/messages.js to use the new method. The line_ends accessor is still > in use by chromium and thus cannot be removed yet. > > R=yangguo@chromium.org > BUG= > > Committed: https://crrev.com/2f3879d54633c4076d38e9fc85b6e2e157c61548 > Cr-Commit-Position: refs/heads/master@{#36398} TBR=yangguo@chromium.org,jgruber@chromium.org,jgruber@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/1995323002 Cr-Commit-Position: refs/heads/master@{#36403}

Import tests from Google V8

c6b6462

These tests are derived from the following files within the Google V8 project: test/mjsunit/harmony/arrow-functions.js

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Import tests from Google V8 #3

Import tests from Google V8 #3

jugglinmike commented Mar 3, 2015

Import tests from Google V8 #3

Are you sure you want to change the base?

Import tests from Google V8 #3

Conversation

jugglinmike commented Mar 3, 2015