Skip to content
This repository has been archived by the owner on Mar 31, 2022. It is now read-only.

Inquiry about omexml.py related to schema location #97

Closed
icaoberg opened this issue Nov 23, 2020 · 2 comments
Closed

Inquiry about omexml.py related to schema location #97

icaoberg opened this issue Nov 23, 2020 · 2 comments
Labels

Comments

@icaoberg
Copy link

xsi:schemaLocation="http://www.openmicroscopy.org/Schemas/OME/2013-06 http://www.openmicroscopy.org/Schemas/OME/2012-03/ome.xsd">

  • Why are you referencing to 2 difference schemas in the line above?
  • Is it necessary to use an older OME model schema? Could you update this to generate images using a newer schema, e.g. 2016?
@votti
Copy link
Collaborator

votti commented Nov 23, 2020

Thanks for pointing this out!

This part from the imctools v1 release is a verbatim copy from the python-bioformats library at the time (included via copying as python-bioformats comes with a tricky dependency on Java).

I think one needs to ask the python-bioformats maintainers why they referenced two schemas.

Checking it now I saw that they actually did fix this bug in the meanwhile and we just missed to update it in imctools :/

The current supported version of imctools v2 does not depend on this code any more but on the ome.xml generation of xtiff that already use the 2016 version of the schema:
https://github.com/BodenmillerGroup/xtiff/blob/d0a7b5cf2626aaa8cdb3a1f6403d8edd9353c782/xtiff.py#L43

Thus I would suggest to move your workflow to imctools v2.
I will also discuss with my colleagues if we still want to fix this for v1.

@votti votti added the V1 label Nov 27, 2020
@jwindhager
Copy link
Contributor

v1 is not supported anymore

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants