Add BCJ2 support #15
Merged
Add BCJ2 support #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
io.SectionReader is needed if there are multiple packed streams in the case of a complex coder.
Saves having to iterate over each coder to calculate the totals each time.
Code previously cheated and passed a single io.ReadCloser which won't work for complex coders. Also tweak the decompressor signature to be an explicit slice rather than variadic. Technically a breaking API change but there are no external decompressors.
Now I (hopefully) understand how the bind pairs work, support complex coders and decompressor chaining (which was probably working by fluke before).
Contains various I/O helpers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the one major missing feature as you invariably cannot extract x86 executables or libraries without it.
Fixes #4
Fixes #6
Fixes #13
Fixes #14