-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix saving / loading of tree sequences after simplification to a subset of sampled individuals #137
Conversation
Codecov Report
@@ Coverage Diff @@
## main #137 +/- ##
==========================================
+ Coverage 84.04% 84.35% +0.30%
==========================================
Files 7 7
Lines 3109 3144 +35
==========================================
+ Hits 2613 2652 +39
+ Misses 496 492 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Merging now. From the changelog:
|
I have a feeling there's a more elegant solution to this. It's more and more clear that a Great Internal Refactoring will have to happen, eventually. The fact that slendr started as a purely SLiM-focused thing, had tskit support bolted on after, and yet after that added support for msprime coalescent models is... starting to show. In the meantime, there's an acute need for Real Research(tm) to be done, so an emergency fix works just fine. |
An attempt at fixing #136.