Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship a nixos module for registering oci-container sidecars #28

Closed
antifuchs opened this issue Aug 26, 2023 · 0 comments · Fixed by #35
Closed

Ship a nixos module for registering oci-container sidecars #28

antifuchs opened this issue Aug 26, 2023 · 0 comments · Fixed by #35

Comments

@antifuchs
Copy link
Collaborator

antifuchs commented Aug 26, 2023

Since tsnsrv is available as a docker image, it would be great if we could integrate that in nixos as well! (Can you tell I run a few oci-containers in a nixos host that would benefit from a sidecar?)

This requires a few steps:

  • An automated step similar to the SRI/narhash update workflow that will pull the image with nix-prefetch-docker and updates a pinned docker reference defining a dockerContainers attribute on the flake.nix, which builds an image containing tsnsrv.
  • The actual module. It should take:
    • The regular tsnsrv customization options
    • A container to sidecar the tsnsrv container to (i.e. share network namespace with)
    • An optional docker image spec, defaulting to what we generate above.
antifuchs added a commit that referenced this issue Aug 28, 2023
This addresses the first part of #28: Now nixos users have an easy way
to reference a docker image that corresponds to the package we're
building.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant