nixos: Add config for defining docker sidecars #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should allow using it in multiple places.
Now, a function generates the commandline args (except for -stateDir, which is by necessity different).
These _very likely_ won't work, but it's a start.
antifuchs
force-pushed
the
docker-sidecar
branch
from
60daa53
to
0ba118a
Compare
antifuchs
force-pushed
the
docker-sidecar
branch
from
4363db7
to
6363f8f
Compare
antifuchs
force-pushed
the
docker-sidecar
branch
from
6363f8f
to
5533518
Compare
antifuchs
force-pushed
the
docker-sidecar
branch
4 times, most recently
from
a557ca6
to
ca27e88
Compare
This is strongly inspired by NixOS/nixpkgs#138423
antifuchs
force-pushed
the
docker-sidecar
branch
from
ca27e88
to
16d77cf
Compare
It's not going to work (SO MANY bugs with non-root and even rootless containers), so let's skip all that.
antifuchs
force-pushed
the
docker-sidecar
branch
from
4fcaeeb
to
9ddf604
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #28, when done.
There is one really unfortunate bit about this: You can't run this rootless or as a non-root user, really (due to several problems on nixos's oci-containers side: NixOS/nixpkgs#138423, NixOS/nixpkgs#207050, containers/podman#18903 and a fun bug in podman too: containers/podman#19800).
...but otherwise, this works really well for me, at least under podman.