Added MaxLength support to RediStore #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PS: We'll need to wait for @kisielk to merge his PR (as linked) upstream first. |
| @@ -62,6 +62,17 @@ func (s *RediStore) Close() { | |||
| s.Pool.Close() | |||
| } | |||
|
|
|||
| // MaxLength restricts the maximum length of new sessions to l. | |||
| // If l is 0 there is no limit to the size of a session, use with caution. | |||
| // The default for a new FilesystemStore is 4096. | |||
There was a problem hiding this comment.
Fixed this up and squashed the commits.
|
@boj If this seems like a good idea to you, I'll merge the FilesystemStore changes. |
values. Tests included. As per gorilla/sessions#2 - this allows a session to exceed the 4096-byte limit commonly enforced by cookie-based stores. Redis has a much larger limit: typically 512MB - http://redis.io/topics/data-types.
|
I've merged the corresponding change in sessions, so go ahead. |
boj
added a commit
that referenced
this pull request
Oct 18, 2013
Added MaxLength support to RediStore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added MaxLength support to RediStore to allow for larger session values. Tests included. Triggered from #4 and gorilla/sessions#17
As per gorilla/sessions#2 - this allows a session to exceed the 4096-byte limit commonly enforced by cookie-based stores. Redis has a much larger limit: typically 512MB - http://redis.io/topics/data-types.