Add visual regression tests

bokeh · Sep 20, 2021 · 51cdaa0 · 51cdaa0
1 parent 417ea42
commit 51cdaa0
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 0 deletions.
diff --git a/...es/linux/Bug__in_issue_#11646__disallows_using_image_texture_as_grid_line's_band_fill.blf b/...es/linux/Bug__in_issue_#11646__disallows_using_image_texture_as_grid_line's_band_fill.blf
@@ -0,0 +1,3 @@
+Plot bbox=[0, 0, 400, 200]
+  LinearAxis bbox=[29, 178, 366, 22]
+  LinearAxis bbox=[0, 5, 29, 173]
diff --git a/...ug__in_issue_#11646__disallows_using_image_texture_as_grid_line's_band_fill.png b/...ug__in_issue_#11646__disallows_using_image_texture_as_grid_line's_band_fill.png
diff --git a/bokehjs/test/integration/regressions.ts b/bokehjs/test/integration/regressions.ts
@@ -17,6 +17,7 @@ import {
   HoverTool,
   TileRenderer, WMTSTileSource,
   Renderer,
+  ImageURLTexture,
 } from "@bokehjs/models"
 
 import {Button, Select, MultiSelect, MultiChoice, RadioGroup} from "@bokehjs/models/widgets"
@@ -1412,4 +1413,19 @@ describe("Bug", () => {
       await view.ready
     })
   })
+
+  describe("in issue #11646", () => {
+    const url = "/images/canvas_createpattern.png"
+
+    it("disallows using image texture as grid line's band fill", async () => {
+      const p = fig([400, 200])
+
+      p.vbar({x: [0], top: [1], alpha: 0.2, hatch_pattern: "."})
+
+      p.xgrid[0].band_hatch_extra = {mycustom: new ImageURLTexture({url})}
+      p.xgrid[0].band_hatch_pattern = "mycustom"
+
+      await display(p)
+    })
+  })
 })