You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In a discussion in Slack around performance, the suggestion came up to consider switching the default for validate_doc from True to False. If/when #12816 is merged, validation will account for about 18% of total runtime, according to my simpleton benchmarks like the one shown in #12799. Feel free to verify this!
I personally can't really judge the value of this validation step and I don't want to imply that it's not useful to have. But I'd like to kick off a discussion about weighing the pros and cons of having it on by default.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
In a discussion in Slack around performance, the suggestion came up to consider switching the default for
validate_doc
fromTrue
toFalse
. If/when #12816 is merged, validation will account for about 18% of total runtime, according to my simpleton benchmarks like the one shown in #12799. Feel free to verify this!I personally can't really judge the value of this validation step and I don't want to imply that it's not useful to have. But I'd like to kick off a discussion about weighing the pros and cons of having it on by default.
Beta Was this translation helpful? Give feedback.
All reactions