-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BEP 9: Minimum downstream versions #10558
Comments
Given the new annual release cycle for Python, both almost equivalent (starting with 3.9). Though I would proceed with the first one, as it gives immediate indication how many versions are supported. |
FYI NEP 29 suggests this for projects:
However, since NEP 29 was adopted, Python has moved from an 18 month cadence to a 12 month cadence, so adopting NEP as-is is more like 4 Python versions. So I agree that "number of versions" is simpler and clearer, and propose:
Do we want also to make statements about Numpy? Two observations:
|
I've gone ahead and started the draft here: https://github.com/bokeh/bokeh/wiki/BEP-9:-Downstream-Version-Support |
cc @bokeh/core I have fleshed out the draft of the BEP a the link above. I think it is ready for review/adoption. Please take a look and register any comments, or 👍 / 👎 here in a comment 👍 from me |
According to https://pypi.org/project/numpy/1.11.3/#files numpy 1.11.3 only supports up to python 3.6. So maybe we should look at a later version of numpy as our minimum. |
@ianthomas23 well, the table there currently is just a record of what has historically been in For 3.0 I am proposing Numpy 1.18 as the min version, are you suggesting the table should be updated to "more realistic" historical minimum versions, even if that disagrees with what was in the |
@bryevdv My apologies, that was only a half-considered comment before I moved on to a meeting. I've actually read and understand it all now! No, don't modify the historic information in the table, and numpy 1.18 seems a sensible choice for bokeh 3.0. So 👍 from me. |
OK I think we already have enough agreement, but I will leave this open for another day in case anyone else wants to chime in. Otherwise I will plan to mark accepted and update the wiki tomorrow |
and also from @ianthomas23 above. I will mark as accepted now. |
Following on from #9295 I'd like to codify our policy for tracking Python versions. I'd to propose that we reduce the burden on ourselves by adopting a policy that is either very simple, reactive to existing precedent, or both, e.g.:
Thoughs @bokeh/dev
The text was updated successfully, but these errors were encountered: