Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need "Edges" only inspected policy for graphs #10637

Closed
bryevdv opened this issue Nov 4, 2020 · 2 comments · Fixed by #10638
Closed

Need "Edges" only inspected policy for graphs #10637

bryevdv opened this issue Nov 4, 2020 · 2 comments · Fixed by #10638

Comments

@bryevdv
Copy link
Member

bryevdv commented Nov 4, 2020

Questions on Twitter about "edge" only hover tooltip:

https://twitter.com/DataDrivenAngel/status/1324015994759745536

and AFIAK this is not possible, since there is not an inspection for just EdgesOnly

On the assumption that (I think) this is a fairly trivial add, I will tentatively schedule for 2.3

@bryevdv
Copy link
Member Author

bryevdv commented Nov 5, 2020

OK well this is slightly complicated by the fact that get_selection_manager only returns a single selection manager, and currently for GraphRenderer it arbitrarily returns the node renderer:

  get_selection_manager(): SelectionManager {
    return this.node_renderer.data_source.selection_manager
  }

I'll have to think on how best to generalize things here but @bokeh/dev if there are any suggestions or thoughts, please chime in

@bryevdv
Copy link
Member Author

bryevdv commented Nov 5, 2020

For purposes of this issue things can probably just be made more specific in the inspection policy here:

    const edge_inspection = graph_view.model.get_selection_manager().get_or_create_inspector(graph_view.edge_view.model)

i.e instead of going through graph_view.model.get_selection_manager actually go through the edge rendere get_selection_manager since that's what is needed. But the general question remains for what (if anything) GraphRenderer.get_selection_manager should do since it has multiple "sub" renderers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants