Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] RadioButtonGroup orientation doesn't have expected effect #11374

Closed
sdc50 opened this issue Jun 23, 2021 · 4 comments · Fixed by #11390
Closed

[BUG] RadioButtonGroup orientation doesn't have expected effect #11374

sdc50 opened this issue Jun 23, 2021 · 4 comments · Fixed by #11390

Comments

@sdc50
Copy link

sdc50 commented Jun 23, 2021

versions:

python: 3.9.5
jupyterlab: 3.0.16
bokeh: 2.3.2

When setting the RadioButtonGroup orientation attribute to 'vertical' I would expect the buttons to be stacked on top of each other vertically (something like rotating the horizontal version 90 degrees):

image

(but with the text oriented horizontally)

However, it seems that they are just stretched in the vertical direction:

image

I'm can't see how this would be useful, so I'm assuming this is a bug. It would be great if orientation='vertical' would stack the buttons on top of each other vertically.

@sdc50 sdc50 added the TRIAGE label Jun 23, 2021
@sdc50
Copy link
Author

sdc50 commented Jun 23, 2021

image

I think either (or both!) of these options would be suitable for an orientation='vertical' configuration.

@mattpap
Copy link
Contributor

mattpap commented Jun 23, 2021

Orientation is not implemented on button groups at all, it's just bad design decisions that lead to it inheriting orientation property from Widget model. Though it shouldn't be too hard to make it work.

@bryevdv
Copy link
Member

bryevdv commented Jun 23, 2021

inheriting orientation property from Widget model

When did orientation get added to Widget ??

@mattpap
Copy link
Contributor

mattpap commented Jun 23, 2021

Awhile back. It's a side effect of JS/TS not having decent support for mixing code in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants