Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_no_typing_extensions_common_combined fails due to thrid-party modules #13632

Closed
mattpap opened this issue Jan 4, 2024 · 0 comments · Fixed by #13633
Closed

test_no_typing_extensions_common_combined fails due to thrid-party modules #13632

mattpap opened this issue Jan 4, 2024 · 0 comments · Fixed by #13633

Comments

@mattpap
Copy link
Contributor

mattpap commented Jan 4, 2024

Fails with:

__________________ test_no_typing_extensions_common_combined ___________________

    def test_no_typing_extensions_common_combined() -> None:
        ''' Basic usage of Bokeh should not result in typing_extensions being
        imported. This test ensures that importing basic modules does not bring in
        typing_extensions.
    
        '''
        proc = run([python, "-c", verify_clean_imports('typing_extensions', MODULES)])
>       assert proc.returncode == 0, "typing_extensions imported in common modules"
E       AssertionError: typing_extensions imported in common modules
E       assert 1 == 0
E        +  where 1 = CompletedProcess(args=['/usr/share/miniconda3/envs/bk-test/bin/python3.9', '-c', "\nimport sys\nfor module in ['bokeh'...xtensions') for key in sys.modules.keys()):\n        print(module)\n        sys.exit(1)\nsys.exit(0)\n"], returncode=1).returncode

tests/codebase/test_no_typing_extensions_common.py:[50]

I tracked this down to dependencies of PIL and sphinx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant