Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Expose the wheel zoom speed in Python #3125
@liuyxpp we are actually in the middle of a big clean-up to ensure that the properties on the python and JS side match each other.
@havocp WheelZoomTool has a default for
However running the test in #3099 doesn't pick up this discrepancy. Thoughts?
referenced this issue
Nov 15, 2015
Why that line exists? @Havoc added that to get things working at all. Currently the client models add all kind of new attributes with abandon and most of them should not get serialized back to the server. But a few like this one should be, but were just overlooked. We should have been more careful in the first place and made client only "viewmodel" objects to store any new, extra, "not intended to be serialized" data, and and kept the main models pure and 1-1 in sync with Python (no extra attrs added). We still should do this some day.