Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that replacing model reconnects signals on new model #8597

Open
philippjfr opened this issue Jan 30, 2019 · 0 comments
Open

Ensure that replacing model reconnects signals on new model #8597

philippjfr opened this issue Jan 30, 2019 · 0 comments

Comments

@philippjfr
Copy link
Contributor

In #8594 we discovered that there doesn't seem to be any mechanism for signals to be reconnected when a model is replaced on another model. For example when replacing the glyph on a GlyphRenderer or the tile_source on a TileRenderer, the renderer should unsubscribe to events on the old model and re-subscribe to any change events on the model but there doesn't seem to be such a mechanism at the moment (unless @bryevdv and I missed something).

It would be nice if a property could handle this automatically by discovering the signals connected to the old model and then setting up those same signals for the model its being replaced with but I know nothing about the feasibility of such a mechanism.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants