Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for spans to grid layout #8710

Closed
mattpap opened this issue Mar 5, 2019 · 6 comments · Fixed by #8775
Closed

Add support for spans to grid layout #8710

mattpap opened this issue Mar 5, 2019 · 6 comments · Fixed by #8775

Comments

@mattpap
Copy link
Contributor

mattpap commented Mar 5, 2019

This is a follow up on issue #8084. Technically speaking this is a regression since the old layout. This is needed to restore functionality of examples/app/spectrogram, etc.

@bryevdv
Copy link
Member

bryevdv commented Mar 5, 2019

Just out of curiousity, how big a lift do you think this is?

@mattpap
Copy link
Contributor Author

mattpap commented Mar 6, 2019

I'm not sure, because I need to figure out how to measure track sizes (under all supported sizing policies), implement new internal data structures that will allow spanning layouts across grid cells, adjust axis alignment algorithm, etc. Definitively it's a bigger chunk of work.

@bryevdv
Copy link
Member

bryevdv commented Mar 6, 2019

Is there anything simple but dumb (and unobtrusive for later) that could be done to cover the 80% case? i.e. could we set min border for top and bottom to be the max value of every plot in a row? And similarly min border left of every plot in a column? I.e. punt on nested cases for now until you can work out a general solution, but do enough to get basic and common cases looking more like they used to?

It will be hard to argue this is not a breaking change. The other alternative is to push 1.1 back which I am fine with personally, but I am not sure how that would impact @philippjfr @jlstevens @jbednar Perhaps they could use 1.1 rc builds in client work for now?

@philippjfr
Copy link
Contributor

It will be hard to argue this is not a breaking change. The other alternative is to push 1.1 back which I am fine with personally, but I am not sure how that would impact @philippjfr @jlstevens @jbednar Perhaps they could use 1.1 rc builds in client work for now?

We are at least a 1.5 weeks away from being ready to push out new releases for our stuff so I'd be happy to postpone for that long. Does that seem like sufficient time? A new dev/rc release would be sufficient for the time being.

@mattpap mattpap modified the milestones: 1.1.1, 1.1 Mar 6, 2019
@philippjfr
Copy link
Contributor

adjust axis alignment algorithm

Will that intersect at all with the axis alignment issue for fixed inner dimensions or is that a whole other chunk of work?

@mattpap
Copy link
Contributor Author

mattpap commented Mar 6, 2019

Will that intersect at all with the axis alignment issue for fixed inner dimensions (...)

To some extent yes, depending on the layout. I will keep that issue in mind fixing this one.

@jbednar jbednar changed the title Add support for spans do grid layout Add support for spans to grid layout Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants