Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] support regexes as URL paths in Django #9946

Open
PeteFein opened this issue Apr 20, 2020 · 2 comments
Open

[FEATURE] support regexes as URL paths in Django #9946

PeteFein opened this issue Apr 20, 2020 · 2 comments

Comments

@PeteFein
Copy link

PeteFein commented Apr 20, 2020

Is your feature request related to a problem? Please describe.
Django server integration only supports fixed-string URL paths in myproject.urls.bokeh_apps. This makes it impossible to customize those apps based on URL arguments - I'd like to construct app instances using database objects referenced in URL slugs.

Describe the solution you'd like
Support regexes in bokeh_apps as URL patterns.

Describe alternatives you've considered
Bypassing bokeh_apps entirely and constructing channel's routing by hand everywhere I need it. This would be sad.

Similar behaviour was requested in bokeh/bokeh-django#4.

Additional context
PR forthcoming. Also tweaks bokeh.server.contexts._RequestProxy to better support Django-style request dictionaries.

@bryevdv
Copy link
Member

bryevdv commented Apr 20, 2020

@PeteFein Is there anything else in bokeh/bokeh-django#4? If not we can close it. If so, can you make individual issues for anything left (then we can close it)?

@PeteFein
Copy link
Author

@PeteFein Is there anything else in bokeh/bokeh-django#4? If not we can close it. If so, can you make individual issues for anything left (then we can close it)?

bokeh/bokeh-django#4 isn't my issue, and I'm not fully sure what's being requested there (it's quite long), so that's probably best left to someone else

@bryevdv bryevdv modified the milestones: 2.1, next May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants