Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation section #10031

Merged
merged 2 commits into from May 17, 2020
Merged

Fix documentation section #10031

merged 2 commits into from May 17, 2020

Conversation

teresafds
Copy link
Contributor

@teresafds teresafds commented May 16, 2020

Sphinx docs build fails when GOOGLE_API_KEY environment variable is not set up.
Adding proper documentation on Dev guid, documentation section.

@bryevdv
Copy link
Member

bryevdv commented May 17, 2020

@teresafds Thanks for the PR! I made some very small sugesstions, let me know what you think

@bryevdv
Copy link
Member

bryevdv commented May 17, 2020

OK the test failure was spurious and unrelated, I will go ahead and merge. Thanks @teresafds !

@bryevdv bryevdv merged commit a332727 into bokeh:master May 17, 2020
@teresafds teresafds deleted the fix_sphinx_build branch May 22, 2020 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add google api key requirements into documentation dev guide
3 participants