New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bryanv/11489 example docstrings #11540
Conversation
@bryevdv Thank you, this looks amazing! I also like the idea of the breadcrumbs! |
@mattpap @hyles-lineata please c.f. 0ac5f9a which makes writing this possible:
resulting in I think we may want to eventually tweak the template, lists of things are not quite as distinct as I might like, in which case maybe field lists are not the best choice. But this should do for now. |
cc @mattpap @hyles-lineata @tcmetzger ready for review. A few comments:
I might possibly look at implementation improvements if I have time, but I don't plan any content changes except as requested (or please feel free t push edits directly to save time):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this PR contains some great improvements, including the added background to the iris dataset and fixing the anchors for annotations!
I left some minor comments/suggestions. One more thought: Most of the texts follow the pattern [A foo plot][demonstrating bar]. I would at least put a comma before "demonstrating", maybe even a period to make things easier to read. For example:
A timeseries plot using stock price data. Demonstrates adding multiple plots to a gridplot.
@bryevdv One more thing: I built the docs from this branch locally and randomly clicked on some of the examples' thumbnails in the gallery page. Most of the linked pages did display the docstrings, but for some, the docstrings didn't show up at all (even though they were present in the code). This happens for example with anscombe, hex_tile, and bar_intervals. This might well be a local issue on my machine, but might be worth looking into to be sure. |
@tcmetzger might be caching, can you try a force-reload?
I guess I didn't do this because it seems pretty awkward w/o
which seemed repetitive across all the examples. But it's probably the best choice. |
@tcmetzger I've updated all the docstrings. |
* make options optional / add error checking * remove ref to old nbviewer site * first batch * split categorical.py into heatmap and dotplot * breadcrumbs for refs * second batch * fix badly name annotations references * third batch * fourth batch * remove debugger * some sampledata page fixes * another batch * small fixes * move some assumtions into the directive * another batch * remove streamline/quiver gallery example * last batch * update verbiage
Updating gallery example to use the new example metadata directive. As a convention, I am making the "refs" links form a series of breadcrumbs which provides more context and affords a better UX. I'm also removing all the
output_file
calls in the gallery examples, as long as I am touching these files anyway.cc @tcmetzger @hyles-lineata I will be working on this in batches all week to get it done for 2.4 but any early feedback would be helpful in case there are course corrections to make.
Note that I only plan to update the examples that are part of the gallery in this PR. I would love to see this extended to all examples, so that perhaps one day every example can automatically render it's own individual page that can also be automatically cross-referenced and linked. Maybe we could push hard on a "Bokeh users! Can you contribute just one docstring?" crowdsourcing for the larger project.