Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added accessible color palette #12923

Merged
merged 6 commits into from
Mar 19, 2023
Merged

Conversation

chinmaychahar
Copy link
Contributor

@chinmaychahar chinmaychahar commented Mar 8, 2023

Updated the color palette used in examples/styling/mathtext/latex_schrodinger.py referencing docs here

Initial color palette Updated color palette

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #12923 (8578eb3) into branch-3.2 (2739e10) will increase coverage by 0.01%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           branch-3.2   #12923      +/-   ##
==============================================
+ Coverage       92.35%   92.36%   +0.01%     
==============================================
  Files             315      315              
  Lines           19936    19969      +33     
==============================================
+ Hits            18411    18444      +33     
  Misses           1525     1525              

@bryevdv
Copy link
Member

bryevdv commented Mar 16, 2023

Hi @chinmaychahar can you update the OP with before/after screenshots? Also we will need to update both gallery thumbnails to go along with this change. Some of the recent merged PRs for accessible palettes would be a good place to look for the required changes e.g. #12946 Let me know if you need a more detailed reference!

@chinmaychahar
Copy link
Contributor Author

HI @bryevdv I've updated the PR with the before/after screenshots. As for the thumbnail, I have the original png but resizing it to the desired 300x300 is leading to reduced quality. Any suggestions on how I can tackle that?

@bryevdv
Copy link
Member

bryevdv commented Mar 17, 2023

cc @ianthomas23 just to wiegh in on the new colors

As for the thumbnail, I have the original png but resizing it to the desired 300x300 is leading to reduced quality

Can you post it for us to examine? The images are just for gallery thumbnails so they are intended to be small / low quality.

@chinmaychahar
Copy link
Contributor Author

chinmaychahar commented Mar 17, 2023

@bryevdv I just updated the new thumbnails. Let me know if they need any changes!

Also, if there are any changes required to the palette too.

@bryevdv
Copy link
Member

bryevdv commented Mar 17, 2023

I wonder if swapping the colors (having the dark blue under the l line, and orange over) would be slightly more aesthetically pleasing.

@chinmaychahar
Copy link
Contributor Author

Sure @bryevdv that looks something like this:

@ianthomas23
Copy link
Member

cc @ianthomas23 just to weigh in on the new colors

I am happy with the new colors. The original colors were taken from wherever I took the original idea from, and the new colors seem much better.

@bryevdv
Copy link
Member

bryevdv commented Mar 17, 2023

@chinmaychahar seeing the swapped version, I don't actually have any preference. Whichever you want to use is fine!

@chinmaychahar
Copy link
Contributor Author

I'm fine with the current version if that's alright. I've updated both the code as well as the thumbnails!

@bryevdv
Copy link
Member

bryevdv commented Mar 19, 2023

Thanks @chinmaychahar !

@bryevdv bryevdv merged commit ba60576 into bokeh:branch-3.2 Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants