Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update text.py with metadata #12990

Merged
merged 9 commits into from
Mar 22, 2023
Merged

Update text.py with metadata #12990

merged 9 commits into from
Mar 22, 2023

Conversation

chinmaychahar
Copy link
Contributor

Added metadata to text.py in examples/plotting/text.py

@codecov
Copy link

codecov bot commented Mar 19, 2023

Codecov Report

Merging #12990 (3dc4bcd) into branch-3.2 (ba60576) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           branch-3.2   #12990   +/-   ##
===========================================
  Coverage       92.36%   92.36%           
===========================================
  Files             315      315           
  Lines           19969    19969           
===========================================
  Hits            18444    18444           
  Misses           1525     1525           

@bryevdv
Copy link
Member

bryevdv commented Mar 19, 2023

@chinmaychahar It looks like maybe this PR branch was branched off the other PR branch rather than off branch-3.2 can you rebase the changes on branch-3.2 (you may need to force-push afterwards). Let me know if I can help with more details on those steps.

@chinmaychahar
Copy link
Contributor Author

@bryevdv I realized there were some previous commits made to the branch-3.2 itself in my fork so I'm not sure if rebasing would help. However, all these changes and corresponding PRs have been successfully merged. Should I consider reverting them from the current branch metadata? I think that should work.

Copy link
Member

@bryevdv bryevdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chinmaychahar a few comments

examples/plotting/text.py Outdated Show resolved Hide resolved
examples/plotting/text.py Outdated Show resolved Hide resolved
@chinmaychahar
Copy link
Contributor Author

Thanks for the comments, updated accordingly

@bryevdv
Copy link
Member

bryevdv commented Mar 22, 2023

Thanks @chinmaychahar !

@bryevdv bryevdv merged commit dfcc216 into bokeh:branch-3.2 Mar 22, 2023
@chinmaychahar chinmaychahar deleted the metadata branch March 23, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add metadata to standalone examples
2 participants