-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Line select metadata #13022
Line select metadata #13022
Conversation
Metadata for line_select.py
Codecov Report
@@ Coverage Diff @@
## branch-3.2 #13022 +/- ##
===========================================
Coverage 92.36% 92.36%
===========================================
Files 315 315
Lines 19969 19969
===========================================
Hits 18444 18444
Misses 1525 1525 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chinmaychahar a few comments
@chinmaychahar it looks like #13019 was already just previously opened almost at the same time by @Azaya89 to for this file. I'd like for the two of you to discuss and let me know which PR to keep, perhaps you can collaborate and both add commits to one PR (by way of comment code suggestions). |
Sure, I'd be happy to collaborate and discuss :D @Azaya89 thanks for the changes you suggested in your PR. I went through them and they were almost identical to mine so I don't mind going forward with either of the PRs. Let me know your thoughts and we can incorporate the changes suggested by @bryevdv in the PR too if you're okay with it. Cheers! |
Oh yeah, I think
Yeah, I think we can merge yours instead, since the changes suggested by @bryevdv is an improvement overall. I will go ahead and close mine now. |
Okay, I'll be making the changes requested to this PR then. Let me know if you have comments to add. Thanks! |
Thanks @chinmaychahar and @Azaya89 ! |
Metadata for examples/plotting/line_select.py was outdated so I updated it acc. to the set template