Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line select metadata #13022

Merged
merged 15 commits into from
Mar 25, 2023
Merged

Conversation

chinmaychahar
Copy link
Contributor

@chinmaychahar chinmaychahar commented Mar 23, 2023

Metadata for examples/plotting/line_select.py was outdated so I updated it acc. to the set template

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #13022 (173821e) into branch-3.2 (56d9ec0) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           branch-3.2   #13022   +/-   ##
===========================================
  Coverage       92.36%   92.36%           
===========================================
  Files             315      315           
  Lines           19969    19969           
===========================================
  Hits            18444    18444           
  Misses           1525     1525           

Copy link
Member

@bryevdv bryevdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chinmaychahar a few comments

examples/plotting/line_select.py Outdated Show resolved Hide resolved
examples/plotting/line_select.py Outdated Show resolved Hide resolved
examples/plotting/line_select.py Outdated Show resolved Hide resolved
@bryevdv
Copy link
Member

bryevdv commented Mar 24, 2023

@chinmaychahar it looks like #13019 was already just previously opened almost at the same time by @Azaya89 to for this file. I'd like for the two of you to discuss and let me know which PR to keep, perhaps you can collaborate and both add commits to one PR (by way of comment code suggestions).

@bryevdv bryevdv mentioned this pull request Mar 24, 2023
2 tasks
@chinmaychahar
Copy link
Contributor Author

Sure, I'd be happy to collaborate and discuss :D

@Azaya89 thanks for the changes you suggested in your PR. I went through them and they were almost identical to mine so I don't mind going forward with either of the PRs.

Let me know your thoughts and we can incorporate the changes suggested by @bryevdv in the PR too if you're okay with it. Cheers!

@Azaya89
Copy link
Member

Azaya89 commented Mar 24, 2023

Sure, I'd be happy to collaborate and discuss :D

@Azaya89 thanks for the changes you suggested in your PR. I went through them and they were almost identical to mine so I don't mind going forward with either of the PRs.

Let me know your thoughts and we can incorporate the changes suggested by @bryevdv in the PR too if you're okay with it. Cheers!

Oh yeah, I think

Sure, I'd be happy to collaborate and discuss :D

@Azaya89 thanks for the changes you suggested in your PR. I went through them and they were almost identical to mine so I don't mind going forward with either of the PRs.

Let me know your thoughts and we can incorporate the changes suggested by @bryevdv in the PR too if you're okay with it. Cheers!

Yeah, I think we can merge yours instead, since the changes suggested by @bryevdv is an improvement overall. I will go ahead and close mine now.

@chinmaychahar
Copy link
Contributor Author

Yeah, I think we can merge yours instead, since the changes suggested by @bryevdv is an improvement overall. I will go ahead and close mine now.

Okay, I'll be making the changes requested to this PR then. Let me know if you have comments to add. Thanks!

@bryevdv
Copy link
Member

bryevdv commented Mar 25, 2023

Thanks @chinmaychahar and @Azaya89 !

@bryevdv bryevdv merged commit 22e6184 into bokeh:branch-3.2 Mar 25, 2023
@chinmaychahar chinmaychahar deleted the line_select_metadata branch March 25, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants