Circle vs Scatter API cleanup #13283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## branch-3.4 #13283 +/- ##
==============================================
- Coverage 92.67% 92.64% -0.03%
==============================================
Files 321 321
Lines 20397 20417 +20
==============================================
+ Hits 18902 18916 +14
- Misses 1495 1501 +6 |
bryevdv
force-pushed
the
bv/circle_scatter_cleanup
branch
5 times, most recently
from
0d76723 to
1b69489
Compare
bryevdv
force-pushed
the
bv/circle_scatter_cleanup
branch
from
1b69489 to
5d77499
Compare
|
@bokeh/core This ended up being a bit more involved than I expected. I am not sure when I will be able to get back to the last mile. But this PR is fairly big, so rather than keep it around in perpetuity I think we should do one of these two things in the next week:
Please let me know thoughts/preferences. |
mattpap
force-pushed
the
bv/circle_scatter_cleanup
branch
from
29e3574 to
80dac99
Compare
|
I went ahead and finished this PR. |
For some reason I thought there was quite a bit more to go, but maybe my memory is just off. Happy to merge and close with an approval. |
mattpap
approved these changes
Nov 7, 2023
|
It was actually quite a bit of work, given there was an API bug that hid a lot of issues and TypeScript wasn't very helpful either with some corner cases. |
|
Thanks @mattpap I'll merge later today! |
mattpap
added a commit
that referenced
this pull request
Dec 6, 2023
* Finalize replacement of Circle glyph with Scatter * Fix deprecation warnings regarding status_iterator * Make documentation CI task fail on error * Fix Pandas' FutureWarning in basic/annotations/band.py * Add --gitignore to isort's command * Fix hatch_pattern in topics/contour/contour_polar.py * Update get_graph_kwargs() of Figure.graph() * Fix sphinxext.bokeh_releases after SRI-related changes * Bump up deprecation version to 3.4.0
Chiemezuo
pushed a commit
to Chiemezuo/bokeh
that referenced
this pull request
Aug 27, 2024
* implement circle/scatter deprecations * update examples * Update bokehjs' implementation * Update bokehjs' tests and examples * p.circle(size=...) -> p.scatter(size=...) * Fix signature type of GlyphAPI.circle() * Replace marker methods with p.scatter() * Replace p.circle() with p.scatter() * Require radius in p.circle() positional args * Statically type TypedGlyphRenderer.*_glyph * Allow to strictly enforce CDS fields in tests * Update visual baselines * Deprecate Figure's scatter methods in bokehjs * Replace p.circle() with p.scatter() in examples/ * Replace p.circle() with p.scatter() in bokehjs/examples/ * Update tests/unit/bokeh/models/test_glyphs.py --------- Co-authored-by: Mateusz Paprocki <mattpap@gmail.com>
Chiemezuo
pushed a commit
to Chiemezuo/bokeh
that referenced
this pull request
Aug 27, 2024
* Finalize replacement of Circle glyph with Scatter * Fix deprecation warnings regarding status_iterator * Make documentation CI task fail on error * Fix Pandas' FutureWarning in basic/annotations/band.py * Add --gitignore to isort's command * Fix hatch_pattern in topics/contour/contour_polar.py * Update get_graph_kwargs() of Figure.graph() * Fix sphinxext.bokeh_releases after SRI-related changes * Bump up deprecation version to 3.4.0
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still WIP, just seeing how full CI performs at this point. I will update this description when the PR is ready.