Circle vs Scatter API cleanup #13283
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-3.4 #13283 +/- ##
==============================================
- Coverage 92.67% 92.64% -0.03%
==============================================
Files 321 321
Lines 20397 20417 +20
==============================================
+ Hits 18902 18916 +14
- Misses 1495 1501 +6 |
bryevdv
force-pushed
the
bv/circle_scatter_cleanup
branch
5 times, most recently
from
0d76723
to
1b69489
Compare
bryevdv
force-pushed
the
bv/circle_scatter_cleanup
branch
from
1b69489
to
5d77499
Compare
|
@bokeh/core This ended up being a bit more involved than I expected. I am not sure when I will be able to get back to the last mile. But this PR is fairly big, so rather than keep it around in perpetuity I think we should do one of these two things in the next week:
Please let me know thoughts/preferences. |
mattpap
force-pushed
the
bv/circle_scatter_cleanup
branch
from
29e3574
to
80dac99
Compare
|
I went ahead and finished this PR. |
For some reason I thought there was quite a bit more to go, but maybe my memory is just off. Happy to merge and close with an approval. |
|
It was actually quite a bit of work, given there was an API bug that hid a lot of issues and TypeScript wasn't very helpful either with some corner cases. |
|
Thanks @mattpap I'll merge later today! |
* Finalize replacement of Circle glyph with Scatter * Fix deprecation warnings regarding status_iterator * Make documentation CI task fail on error * Fix Pandas' FutureWarning in basic/annotations/band.py * Add --gitignore to isort's command * Fix hatch_pattern in topics/contour/contour_polar.py * Update get_graph_kwargs() of Figure.graph() * Fix sphinxext.bokeh_releases after SRI-related changes * Bump up deprecation version to 3.4.0
Still WIP, just seeing how full CI performs at this point. I will update this description when the PR is ready.