Add support for canvas layouts and sub-plots #13286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattpap
force-pushed
the
mattpap/3821_canvas_layouts
branch
2 times, most recently
from
90beaea
to
e29526a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## branch-3.4 #13286 +/- ##
===============================================
- Coverage 92.44% 58.32% -34.13%
===============================================
Files 315 317 +2
Lines 20156 20211 +55
===============================================
- Hits 18634 11788 -6846
- Misses 1522 8423 +6901 |
mattpap
force-pushed
the
mattpap/3821_canvas_layouts
branch
from
96ded0d
to
f1bf5de
Compare
mattpap
force-pushed
the
mattpap/3821_canvas_layouts
branch
from
c6fbf96
to
ff4af99
Compare
4 tasks
|
This isn't salvageable at this point. I will close this PR but keep the branch and continue extracting useful stuff from it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very early prototype and a lot of work is needed to make this viable. Currently this allows to create single canvas grid plots with multiple
PlotRenderers.PlotRendereris an equivalent ofPlot, but it doesn't participate in CSS layout and doesn't own a canvas. LaterPlotwill be reimplemented usingPlotRenderer, but for how I'm trying to avoid breaking too many things. UI events and some of the tools already work.Example. Nothing special for now, except it's a single canvas. I will be updating this as new features are implemented.
frame_heightremoves xlabel #13225