Skip to content

Make server resource URLs root-relative by default #13391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

mattpap
Copy link
Contributor

@mattpap mattpap commented Sep 23, 2023

Fixes the regression introduced in PR #13041. This makes server resource URLs root-relative (i.e. no protocol, host or port), unless specified otherwise.

fixes #13170

@mattpap mattpap added this to the 3.3 milestone Sep 23, 2023
@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Merging #13391 (1226c39) into branch-3.3 (0bdaa42) will increase coverage by 0.00%.
Report is 1 commits behind head on branch-3.3.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           branch-3.3   #13391   +/-   ##
===========================================
  Coverage       92.44%   92.45%           
===========================================
  Files             317      317           
  Lines           20264    20268    +4     
===========================================
+ Hits            18734    18738    +4     
  Misses           1530     1530           

@mattpap mattpap merged commit 5d7d60f into branch-3.3 Sep 27, 2023
@mattpap mattpap deleted the mattpap/13170_server_resource_urls branch September 27, 2023 07:19
Chiemezuo pushed a commit to Chiemezuo/bokeh that referenced this pull request Aug 27, 2024
* Make server resource URLs root-relative by default

* Robustify chromedriver acquisition in tests

* Update docstring
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Static paths loaded always from localhost in Bokeh 3.1.1
2 participants