Improve DataRangePicker's calendar click behavior
#13466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## branch-3.4 #13466 +/- ##
==============================================
- Coverage 92.67% 92.65% -0.02%
==============================================
Files 320 320
Lines 20362 20362
==============================================
- Hits 18870 18867 -3
- Misses 1492 1495 +3 |
|
I've confirmed this fixes the bug. Here's a screencast Screen.Recording.2023-10-20.at.10.53.38.mov |
bryevdv
approved these changes
Oct 30, 2023
|
I will test this separately from this PR. |
Merged
bryevdv
pushed a commit
that referenced
this pull request
Oct 31, 2023
bryevdv
pushed a commit
that referenced
this pull request
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I currently can't capture screencasts after a system upgrade. The behaviour is as one would expect from pure flatpickr, i.e. calendar click starts a range selection. To select a single date one needs to click a date twice.
TODO:
fixes #13462