handle negative microseconds with %f format #13495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 29, 2023 02:25
Codecov Report
@@ Coverage Diff @@
## branch-3.4 #13495 +/- ##
==============================================
- Coverage 92.67% 92.62% -0.05%
==============================================
Files 320 321 +1
Lines 20362 20383 +21
==============================================
+ Hits 18870 18880 +10
- Misses 1492 1503 +11 |
Which btw. is not maintained anymore, so it's up to us to fix any underlying problems, or switch to another library. |
bryevdv
approved these changes
Oct 30, 2023
Probably the best solution, but this will have to do for now |
Merged
bryevdv
pushed a commit
that referenced
this pull request
Oct 31, 2023
* fix %f formatting for pre epoch * add test --------- Co-authored-by: maxmuendlein <max.muendlein@stud-mail.uni-wuerzburg.de>
bryevdv
pushed a commit
that referenced
this pull request
Nov 1, 2023
* fix %f formatting for pre epoch * add test --------- Co-authored-by: maxmuendlein <max.muendlein@stud-mail.uni-wuerzburg.de>
bryevdv
added
status: accepted
and removed
status: ready
type: task
tag: component: bokehjs
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All pull requests must have an associated issue in the issue tracker. If there
isn't one, please go open an issue describing the defect, deficiency or desired
feature. You can read more about our issue and PR processes in the
wiki.
Note: The main bug of #13067 is within the external timezone library