New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable 'use strict';
, improve error handling and update @bokeh/slickgrid
#13523
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-3.4 #13523 +/- ##
===========================================
Coverage 92.61% 92.61%
===========================================
Files 321 321
Lines 20456 20456
===========================================
Hits 18945 18945
Misses 1511 1511 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change requested for the phrasing, and a suggestion to consider for presentation.
d68b43d
to
b94bd99
Compare
I updated the error message and made its footprint smaller (by using a scrollable and resizable div). |
In case of an exception when loading bokehjs, if partially loaded then the output will look like this:
fixes #13499
fixes #13337
fixes #9684