Repository navigation
Enable 'use strict';, improve error handling and update @bokeh/slickgrid - #13523
Merged
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-3.4 #13523 +/- ##
===========================================
Coverage 92.61% 92.61%
===========================================
Files 321 321
Lines 20456 20456
===========================================
Hits 18945 18945
Misses 1511 1511 |
bryevdv
approved these changes
Nov 17, 2023
bryevdv
left a comment
bryevdv
left a comment
Member
There was a problem hiding this comment.
One change requested for the phrasing, and a suggestion to consider for presentation.
mattpap
force-pushed
the
mattpap/13499_use_strict
branch
from
November 17, 2023 18:43
d68b43d to
b94bd99
Compare
Contributor
Author
|
I updated the error message and made its footprint smaller (by using a scrollable and resizable div). |
Chiemezuo
pushed a commit
to Chiemezuo/bokeh
that referenced
this pull request
Aug 27, 2024
…ckgrid` (bokeh#13523) * Include `'use strict`;` directive in bundles * Better error handling in autoload_nb_js.js * Module not found should result in `failed` status * Upgrade @bokeh/slickgrid to version 2.4.4103 * Fix spelling in load_module() * Update template's checksum * Improve the error message * Added a release note
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case of an exception when loading bokehjs, if partially loaded then the output will look like this:
fixes #13499
fixes #13337
fixes #9684