Make all generated HTML elements have unique and safe IDs #13636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryevdv
approved these changes
Jan 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-3.4 #13636 +/- ##
===========================================
Coverage 92.55% 92.56%
===========================================
Files 323 323
Lines 20509 20509
===========================================
+ Hits 18983 18985 +2
+ Misses 1526 1524 -2 |
bryevdv
pushed a commit
that referenced
this pull request
Jan 24, 2024
* Make all generated HTML elements have unique and safe IDs * Fix type of `title in `html_page_for_render_items()` * Fix `__all__` in src/bokeh/embed/notebook.py * Make function's signature more readable * Add regression tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes all generated HTML elements to use unique and safe IDs. It also addresses some trivia I found when fixing the issue.
fixes #13629