Correctly render nonselected WebGL image glyphs #13684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianthomas23
force-pushed
the
ianthomas23/13678_webgl_image_tap
branch
from
227b324
to
2d59643
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-3.4 #13684 +/- ##
==============================================
+ Coverage 91.28% 92.59% +1.30%
==============================================
Files 323 323
Lines 20525 20575 +50
==============================================
+ Hits 18736 19051 +315
+ Misses 1789 1524 -265 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nonselected WebGL image glyphs weren't rendered correctly as the initial implementation didn't correctly handle
dataversusvisualproperties. This PR fixes it.See the new visual baseline image. Before this PR the generated WebGL plot is empty.