move switcher.json back to docs/bokeh #13903
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosc9575
commented
May 18, 2024
| @@ -55,9 +55,9 @@ def root(): | |||
| return redirect("en/latest/index.html") | |||
|
|
|||
|
|
|||
| @app.route("/switcher.json") | |||
| @app.route("/en/switcher.json") | |||
There was a problem hiding this comment.
Combining en/latest/ and ../switcher.json results in /en/switcher.json for route.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-3.5 #13903 +/- ##
==============================================
+ Coverage 91.57% 93.15% +1.58%
==============================================
Files 326 282 -44
Lines 20737 20031 -706
==============================================
- Hits 18990 18660 -330
+ Misses 1747 1371 -376 |
mattpap
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the file
switcher.jsonback todocs/bokehwhich should reenable the release build for docs.The path
../switcher.jsonis working inconf.py, too, and the behavoir is the same as in #13901.Edit: Maybe we can squash the latest two commits to reduce the changes in the git history after this is accepted and merged.