Spectrogram template-ing #2468
Merged
Spectrogram template-ing #2468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready for review. |
| return freq_slider, gain_slider, spectrum, signal, spec, eq | ||
|
|
||
|
|
||
| def get_layout(): |
There was a problem hiding this comment.
This is unused, right? Let's just delete it, I think leaving it would be confusing.
|
@bryevdv I've removed get_layout that I left lurking around. |
| <script type="text/javascript">{{ raw|safe }}</script> | ||
| {% endfor %} | ||
|
|
||
| {{ script|indent(8)|safe }} |
There was a problem hiding this comment.
curious... why indent (8)?
There was a problem hiding this comment.
we seem to do it elsewhere.......(aka no good reason i am a 🐑)
|
LGTM, but I could not test it because some problem in my ALSA library (pyaudio is always messy in this machine... I will try later to dig in the issue so I can test it). |
|
@bryevdv, I need your input here... since LGTM, I will merge this one in a little bit if you don't stop me... |
|
OK, merging this one now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handles "use new embed.components to have better layout design" on #2433