New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canavandl/1441 colorbar #4916
Canavandl/1441 colorbar #4916
Conversation
…ty and add deprecation warning
Apart from code issues (including the floating tick above the color bar), are there any visual components that I'm missing. Specifically:
|
Yes (optionally) - if the ticks are on the right, the default position should be on the top left - left aligned with the actual color bar (not aligned with the text)
I think it's fine to leave that for later
I think this should have the same padding, margin etc properties as legend, specifically as proposed by @almarklein here: #4526 - so the same properties as legend will have! |
from .renderers import GuideRenderer, GlyphRenderer | ||
from .tickers import Ticker, BasicTicker | ||
|
||
class Legend(GuideRenderer): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change needs an explanation (should have been done in the initial commit). There might be unforeseen consequences of this change across code base. This is also why one should refrain from using "refactoring" near such changes, as this changes both APIs and functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
superceded by #4931 |
(ninja edit) Note: this branch is branched from #4851 and should only be merged after the parent.
Proof-of-concept color bar
The code is a mess (lots of copy pasta from axis.coffee and hardcoded values), but serves to generate a POC color bar. (this uses a LogColorMapper, but Linear looks identical except for the tick spacing).