New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix steaming for DataFrame-based ColumnDataSource #6738
Conversation
@p-himik just a heads up, for this to go into |
FYI the changed code in the merge conflict is to deal with the multi-index case, it makes a CDS key by joining the sub-index col names with |
a147e25
to
a8ee842
Compare
@bryevdv The tests contain a fair amount of repetitions - not only mine but many tests in |
@p-himik we try to use |
|
||
ds.data._stream = stream_wrapper | ||
|
||
ds._stream(pd.Series([11, 21, 31], index=list('abc')), 7) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OH this is interesting, I didn't realize Series
could be used this way.
@p-himik Thanks the tests look good. I agree that there is a fair amount of boilerplate, but I'm willing to defer cleanup up on that until the entire module gets converted to use Thanks!! |
Fixes #6667