Ci windows appveyor pr #8226
Ci windows appveyor pr #8226
Conversation
xavArtley
commented
Sep 7, 2018
xavArtley
commented
- issues: fixes Appveyor build and test for windows #8225
* Add balanced theme * Shorten tick out * Rename balanced to caliber and add inline plots to docstring * Separate shows
* Added __copy__ and __deepcopy__ hooks to PropertyValueColumnData. Modified ColumnDataSource.__init__ to make deep copies of supplied dicts. Changed the docstring of ColumnDataSource to insert a note documenting this behaviour. * changed ColumnDataSource to create a shallow copy of passed dicts instead. * Added a blank line after note directive in ColumnDataSource docstring. Changed __copy__ to just use the dict built-in instead of copy.copy * Removed modifications from sources.py, except for note in docstring. Added tests for ColumnDataSource to check if initializing with PropertyValueColumnData creates a shallow copy. Addet tests for PropertyValueColumnData to check __copy__ and __deepcopy__ hooks. * fixed missing newlines at EOF * fixed missing newlines at EOF * missed newline error
* don't dynamically generate bokeh.command docstring * static docstring, 100% cov for bootstrap * add tornado to info, 100% cov * 100% cov for html * factor common svg/png code, better size warning, 100% cov * 100% cov for bokeh.util.version * session_id coverage
* Added unit/integration tests for python3.7 * Remove python3.7 integration test
| deps += '" "'.join(s for s in spec) | ||
| deps += '"' | ||
| else: | ||
| deps += '" "'.join(s for s in spec) |
There was a problem hiding this comment.
this doesn't seem correct in the non-windows case. It looks like it would produce:
foo" "bar" "baz
with no quotes at the beginning. I think it needs to be deps += " ".join(...) as before.
However, is it possible to a avoid changing this script at all, and put the necessary logic to handle this output in the windows scripts? AFAIK this works on windows with the original script:
for /F "delims=" %i in ('python scripts\deps.py build run') do (conda install %i)
There was a problem hiding this comment.
Tho perhaps that windows command is much slower (I think it does a separate install for each pkg?)
There was a problem hiding this comment.
On windows i never succeed to run the command of the documentation directly because of node <>=. Thats why i need to use quotes. With powershell or dos
|
@xavArtley is it possible to rebase on lastest master? I think this is branched from an older commit and that is why there is exrta cruft in the commit log |
|
|
||
| environment: | ||
| matrix: | ||
| # Python 3.6 |
There was a problem hiding this comment.
I think the latest or possibly upcoming miniconda is 3.7 I would say leave the comment out since it will soon be outdated if it is not already
| alt="Current AppVeyor build status" /> | ||
| </a> | ||
| </td> | ||
| </tr> |
There was a problem hiding this comment.
We will need to make a bokeh project account and have the link here refer to that. For now can you just leave this out? I need to re-edit the README anyway, I will re-organize that table to accommodate this badge at that point.
There was a problem hiding this comment.
OK we already have a bokeh project on Appveyor, linked under the "bokeh-integrations" GitHub account. If you let me know any specific configuration necessary, I can make any changes.
There was a problem hiding this comment.
I just sign in on appveyor with my github account and add the repo to projects. Now each time a modification is done its trigger a build
|
I'll will make a cleaner pr next week. I'm now in holidays for one week andhave just a tablet |
|
I close this PR, I made a cleaner branch |
|
OK, look forward to it, let me know if I can help with anything |
