Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update from_networkx for fixed layout #8312

Merged
merged 3 commits into from
Oct 9, 2018
Merged

update from_networkx for fixed layout #8312

merged 3 commits into from
Oct 9, 2018

Conversation

komo-fr
Copy link
Contributor

@komo-fr komo-fr commented Oct 9, 2018

@bryevdv
Copy link
Member

bryevdv commented Oct 9, 2018

Not sure why the appveyor build would fail, I've restarted it

@mattpap
Copy link
Contributor

mattpap commented Oct 9, 2018

Not sure why the appveyor build would fail, I've restarted it.

How does this work? I wasn't able to restart builds so far.

@bryevdv
Copy link
Member

bryevdv commented Oct 9, 2018 •
edited
Loading

How does this work? I wasn't able to restart builds so far.

I had to log in as bokeh-integrations there's probably some access setting to allow other accounts. The option itself we in the upper right of the page.

@bryevdv
Copy link
Member

bryevdv commented Oct 9, 2018

@komo-fr This looks good to me, an the restarted build is green. Is there anything else you wanted to do, or is this good to merge from your end?

@komo-fr
Copy link
Contributor Author

komo-fr commented Oct 9, 2018

@bryevdv
Thank you for everything. I am grateful if you would merge it.
Ideally, there may be tasks such as adding example codes. However, considering that it is just before release, I think that they are NOT urgent tasks.

@bryevdv bryevdv merged commit eb730e6 into bokeh:master Oct 9, 2018
@komo-fr komo-fr deleted the 8311_from_networkx_for_fixed_layout branch October 10, 2018 08:56
xavArtley pushed a commit to xavArtley/bokeh that referenced this pull request Oct 15, 2018
@komo-fr
update from_networkx for fixed layout (bokeh#8312)
7bf3d50 
* Update from_networkx to handle both fixed layout and layout function

* Update docstring for a fixed layout

* Add warning if node keys in the fixed layout don't match node keys in the graph.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryevdv bryevdv bryevdv approved these changes

Assignees
No one assigned
Labels
status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] ‘from_networkx’ function for a fixed layout
3 participants
@komo-fr @bryevdv @mattpap