Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geodot crashes godot #24

Closed
chrisgraf opened this issue May 24, 2020 · 4 comments
Closed

geodot crashes godot #24

chrisgraf opened this issue May 24, 2020 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@chrisgraf
Copy link
Member

chrisgraf commented May 24, 2020

2020-05-24_01-35-08-427 [ERR ] [main] Phytocoenosis CSV file does not exist, expected it at vegetation/phytocoenosis.csv
ERROR: Geodot::get_image: No valid data was available for the requested path and position!
   At: geodot.cpp:26.
ERROR: Geodot::get_image: No valid data was available for the requested path and position!
   At: geodot.cpp:26.
handle_crash: Program crashed with signal 11
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[1] /lib/x86_64-linux-gnu/libc.so.6(+0x46210) [0x7f36193af210] (??:0)
[2] GeoRaster::get_as_array() (??:0)
[3] GeoRaster::get_histogram() (??:0)
[4] GeoRaster::get_most_common(int) (??:0)
[5] godot::GeoImage::get_most_common(int) (??:0)
[6] godot_variant godot::__wrapped_method<godot::GeoImage, godot::Array, int>(void*, void*, void*, int, godot_variant**) (??:0)
[7] ../Godot_v3.2.1-stable_x11.64() [0x25cab97] (<artificial>:?)
@chrisgraf chrisgraf added the bug Something isn't working label May 24, 2020
@kb173
Copy link
Member

kb173 commented May 24, 2020

ERROR: Geodot::get_image: No valid data was available for the requested path and position!
   At: geodot.cpp:26.

This always hints at missing data or invalid paths. The subsequent crashes are caused by trying to access this data.

I'm assuming this happened in the LandscapeLab and the geodata path is incorrect, since the phytocoenosis CSV file could also not be found (first error). I'm assuming it may be related to boku-ilen/landscapelab@82f3635? (But this issue should be moved to the LandscapeLab if it's related to the geopackage restructure)

@chrisgraf
Copy link
Member Author

I know the file is missing. my point is: it still must not crash the engine but return back an "exception"-equivalent, which can be handled by the calling code

@chrisgraf
Copy link
Member Author

and yes, this commit should not have been pushed yet, sorry

@kb173
Copy link
Member

kb173 commented Jan 28, 2021

#26 describes the specific issue left to fix here.

@kb173 kb173 closed this as completed Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants