Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: clean up coverage tasks #12

Merged
merged 1 commit into from Jun 22, 2022
Merged

ci: clean up coverage tasks #12

merged 1 commit into from Jun 22, 2022

Conversation

thermokarst
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2022

Codecov Report

Merging #12 (fa76e42) into main (e2b8e67) will increase coverage by 5.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   89.01%   94.21%   +5.19%     
==========================================
  Files           8       18      +10     
  Lines         255      588     +333     
  Branches       43        0      -43     
==========================================
+ Hits          227      554     +327     
- Misses         26       34       +8     
+ Partials        2        0       -2     
Impacted Files Coverage Δ
q2_moshpit/checkm/tests/test_utils.py 95.45% <0.00%> (ø)
q2_moshpit/metabat2/tests/test_metabat2.py 98.93% <0.00%> (ø)
q2_moshpit/checkm/tests/test_checkm.py 98.73% <0.00%> (ø)
q2_moshpit/metabat2/tests/test_utils.py 96.29% <0.00%> (ø)
q2_moshpit/__init__.py 100.00% <0.00%> (ø)
q2_moshpit/checkm/__init__.py 100.00% <0.00%> (ø)
q2_moshpit/checkm/tests/test_plots.py 96.42% <0.00%> (ø)
q2_moshpit/_version.py 100.00% <0.00%> (ø)
q2_moshpit/tests/test_utils.py 95.12% <0.00%> (ø)
q2_moshpit/metabat2/__init__.py 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2b8e67...fa76e42. Read the comment docs.

@thermokarst
Copy link
Contributor Author

x-ref bokulich-lab/q2-assembly#20 - this plugin will have the same issue. we can sort it out in this pr, or another, your call @misialq

@misialq
Copy link
Contributor

misialq commented Jun 17, 2022

Hey @thermokarst, many thanks for these updates - these look great! I think I'd merge this one and take care of the other issue in a separate PR (although I am not entirely sure what that would entail, as pointed out here: bokulich-lab/q2-assembly#16 (comment)). I'll also update the CI of the other plugins to follow the changes introduced here.

@thermokarst
Copy link
Contributor Author

A separate PR sounds good. RE your question to Evan in that q2-assembly post - the answer is "yes" - this is a problem in any of your plugins - you'll need to use conda for all dependencies in order to correctly build and publish on Library.

I think I'm set on this end for this PR, so feel free to merge if/when you're ready. Thanks!

@misialq misialq merged commit e3c65de into bokulich-lab:main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants