* Added movementRatio prop, this will allow the box to stick to the…
#391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pointer in a flexbox layout.
|
This build failed, it seas 'movementRatio' is undefined even though the default prop is set to 1. Any ideas? |
|
@martinmcneela Thanks for your work. Please try default value like follwing. |
|
Great I'll give that a go first chance I get. |
|
@bokuweb that fixed it thanks. |
bokuweb
requested changes
Dec 11, 2018
* Updated README to include new prop.
|
Change request made and updated. |
|
@martinmcneela Sorry for late. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't have an existing issue (that I could see).
The problem:
When using flexbox the user would see a detachment in the box and the cursor that is resizing it.
The solution:
I have added
movementRatioprop that is not required and defaults to '1' so it won't effect existing functionality.When using flexbox layout (or anytime you want) you can set the prop to '2' to allow the handle being dragged to stick to the cursor.
Testing:
I have tested with and without this props and everything is working as expected. I have also added two now stories to illustrate the issue it is solving.
Notes:
This is my first ever PR to an open source repo, so I am happy to take any feedback and make the required changes.