Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: env variables improvements #61

Merged
merged 1 commit into from
May 24, 2024
Merged

build: env variables improvements #61

merged 1 commit into from
May 24, 2024

Conversation

sebastianmusial
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

  • We had to set up the app URL in multiple places
  • hard configuration for multiple instances

What is the new behavior?

  • added new env variable (.env) - APP_URL which represents the main app URL for the iframe

Does this PR introduce a breaking change?

  • Yes
  • No

@sebastianmusial sebastianmusial merged commit 7ab7de7 into main May 24, 2024
1 check passed
@sebastianmusial sebastianmusial deleted the build/env-variables branch May 24, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivierhalupczok olivierhalupczok olivierhalupczok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastianmusial @olivierhalupczok