Replace white/blacklists with error hanlder and never re-raise errors #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will fix bolshakov#91. It still needs some tests.
zeisler
changed the title
…light about this error call `handler#handle(error)`.
…unding/stoplight into error-handler-module-triquels
|
Do you have any feedback on this? @tfausak |
|
I'm sorry it took me so long to look at this. I like some of what you've done here. In particular I think sending the error to a method in Stoplight (via This feels like a good improvement on my work in #97. I want to think a little more about how to handle the fallback case without so much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tfausak Checkout this PR when you have a chance. Thanks!