Insure only rescuing safe errors #99
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will fix bolshakov#91. It still needs some tests.
…light about this error call `handler#handle(error)`.
…unding/stoplight into error-handler-module-triquels
Needs test refactor and fixing.
|
I still feel like this is too complicated. See 2a12612 for my approach. |
|
@tfausak I think your commit make sense, I'll feel good how it prevent users from easily shooting them selves in the foot. I also see the performance improvements with using a Proc that gets used over and over again instead instantiating a new object every time for the error handler. |
|
I appreciate the work that you put into this, and I'm glad that you helped me figure out the best way to solve this problem. That being said, I'm going to move forward with my changes in #97. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dynamic
Module.===but insure only rescuing safe errorsNeeds test refactor and fixing.