Fixed a bug with some utf8 characters becoming question marks after savi... #2804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aving into database.
|
We've been trying out several tweaks to this part of the code, but so far we haven't found a foolproof solution. |
|
@bobdenotter it worked for #2648 and also see the link in this comment |
|
Thanks for that link @dwr, that's exactly the info i wanted. Since we've been tweaking that part of the code, it's good to have some information to back it up. I'm going to merge in your PR, and follow up with some comments in the code. |
bobdenotter
added a commit
that referenced
this pull request
Feb 13, 2015
Fixed a bug with some utf8 characters becoming question marks after savi...
bobdenotter
added a commit
that referenced
this pull request
Feb 13, 2015
GwendolenLynch
added a commit
that referenced
this pull request
Feb 13, 2015
Add some comments to the fix introduced in #2804
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ng into database.
Fixes #2648