[Bug] Imagefield with attrib breaks repeaters

[SvanteRichter]

Tested on 3.0.11 and master.

The image fields attribute fields do not seem to get the right name/key when the save is done. This does not happen on other fields that post multiple values like the geolocation field. The effect of this seems to be that only the last repeater in the set seems to be saved/shown on refresh.

Looking at the posted data in devtools shows the following for the repeater (the image field was left empty on save):

templatefields[slides][0][image][file]:
templatefields[slides]_#_image[title]:
templatefields[slides]_#_image[alt]:
templatefields[slides][0][teaser_text]:<p>test1</p>

Here is the templatefields config I tested with:

templatefields:
    extrafields.twig:
        section_1:
            type: text
            label: Section 1
        section_2:
            type: html
            label: Section 2
        image:
            type: image
            attrib: [title, alt]
            extensions: [ gif, jpg, png ]
            label: Image
        slides:
            type: repeater
            fields:
                image:
                    type: image
                    extensions: [ gif, jpg, png ]
                    label: Image
                teaser_text:
                    type: html
                    height: 300px
                    label: Teaser Text

[rossriley]

Looks like it's time for my favourite activity, debugging js.

[SvanteRichter]

@rossriley I actually thought I'd have a look at this later today or tomorrow. So, if you want to take a look at the hydration on the frontend instead (if you have time), we can split the work that way.

(And I should probably have self-assigned it when I posted it...)

[rossriley]

cool, well the answer will be in the renumber method inside the fieldRepeater.js file. That's what turns the # into a properly indexed number.

[SvanteRichter]

This was actually an issue in all repeaters, not just templatefields