Sorting preference is not taken into account when getting content by taxonomy

[flrvt]

In Frontend.php on line 239 the getContentByTaxonomy() function is called including the parameter 'order' like so:

$content = $app['storage']->getContentByTaxonomy($taxonomytype, $slug, array('limit' => $amount, 'order' => $order, 'page' => $page));

In Storage.php this parameter is not taken into account and no sorting is done.

Not so familiar with the code, but this may fix it:

// line 1181
$order = $parameters['order'] ? : 'id ASC';
// line 1197
$query = "SELECT * FROM $tablename" . $where . " ORDER BY " . $order;

[bobdenotter]

Thanks! Looks like you're right. And I think your assumptions about where the changes should go are spot on. Should I change this manually, or will you make a PR, for some github-karma? ;-)

[infodebrid]

Hi,

Not sure this what you are talking about, but we used

{% for related in relatedrecords|order('title')%}

Which is working pretty good

[bobdenotter]

@infodebrid What you mention works fine on a separate page. What @flrvt means is an overview-page like /categories/movies. :-)

[flrvt]

I was hesitant creating a pull request because I'm a rookie in Git ;). But give me a moment to figure it out, and i'll do it asap!

[bobdenotter]

Sure! Check out this video, for a quick tutorial. Let me know if you get stuck, I'll gladly help! :-)

http://www.youtube.com/watch?v=YTbRzhQju4c

[GwendolenLynch]

@flrvt I have done plenty of stupid Git stuff-ups lately... I am also here to help where I can (just another member a good community)

[flrvt]

Pull request done!