Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client side validation including #2956 fix #2997

Merged
merged 39 commits into from
Mar 3, 2015
Merged

Client side validation including #2956 fix #2997

merged 39 commits into from
Mar 3, 2015

Conversation

rarila
Copy link
Contributor

@rarila rarila commented Mar 2, 2015

  • Add client side validation (first for floats only)
  • Distinct error messages
  • Translatable error messages
  • Fixes float type buggy for clients with locale fr #2956
  • Float field now not html5 number field anymore
  • , and . allowed as decimal point for floats
  • You now can click on the field part of the alert to jump to the field with the error
  • Correct label names, not internal field names. (Only floats sofar)

Changelog

rarila added 30 commits March 2, 2015 22:09
@rarila
Convert float inpout from number to text
351f8f7
@rarila
Add validation info to input element
92569af
@rarila
Add error messages
c825b0b
@rarila
Add js form validation object
f18b4ed
@rarila
Move validation functions ovr to validation obj
0fc063c
@rarila
Strip validation of a single field into own function
7157142
@rarila
Strip error style removal into own function
28c9461
@rarila
Strip error style adding into own function
4c34a27
@rarila
Strip showing of alertbox into own function
a1859d6
@rarila
Correction of docblock
1e535ab
@rarila
Comments
c4326e3
@rarila
Change how float type validation is defined
fa97544
@rarila
Add basic sceleton for validation
36fcf1a
@rarila
Add check for floats
43b8bb4
@rarila
Add check for required
def5278
@rarila
Add check for min value
f5e78ce
@rarila
Add check for max value
502e70a
@rarila
Correction to error messages
91577f7
@rarila
Add a for id to float inputs label
f672779
@rarila
Get correct label for error messge, not field name
6cce87d
@rarila
Remove now unused html5 attributes from float field
58d6ff0
@rarila
Adjust min/max test for numbers with commas as decimal mark and allow…
211c8ca 
… empty fields
@rarila
Allow ',' and '.' as decimal point on posting
4d37ac1
@rarila
Move that functionality from Content to Backend
ab2b858
@rarila
Return floats with localized decimal point
3d4cf47
@rarila
Reset valid to true when no error found
0405928
@rarila
Out float check in own method
7131808
@rarila
Move required check in own method
feafe4e
@rarila
Move minimum check in own method
2bbb8ee
@rarila
Move maximum check in own method
8c6a4bc
@rarila rarila mentioned this pull request Mar 2, 2015
Merged
@bobdenotter
Copy link
Member

emmastone-thumbsup1

bobdenotter added a commit that referenced this pull request Mar 3, 2015
@bobdenotter
Merge pull request #2997 from rarila/client-side-validation
3deb8d5 
Client side validation including #2956 fix
@bobdenotter bobdenotter merged commit 3deb8d5 into bolt:master Mar 3, 2015
@rarila rarila deleted the client-side-validation branch March 3, 2015 18:22
@rarila
Copy link
Contributor Author

rarila commented Mar 3, 2015

👍👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rarila @bobdenotter